Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 16950008: Rewrite scoped_ptr<T>(NULL) to use the default ctor in base/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in base/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the base/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206116

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M base/debug/trace_event_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/scoped_vector_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/prefs/json_pref_store.cc View 1 chunk +1 line, -3 lines 2 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
7 years, 6 months ago (2013-06-13 14:46:32 UTC) #1
willchan no longer on Chromium
lgtm https://codereview.chromium.org/16950008/diff/1/base/prefs/json_pref_store.cc File base/prefs/json_pref_store.cc (right): https://codereview.chromium.org/16950008/diff/1/base/prefs/json_pref_store.cc#newcode161 base/prefs/json_pref_store.cc:161: read_error_(PREF_READ_ERROR_OTHER) {} While I like {} in my ...
7 years, 6 months ago (2013-06-13 15:01:11 UTC) #2
dcheng
https://codereview.chromium.org/16950008/diff/1/base/prefs/json_pref_store.cc File base/prefs/json_pref_store.cc (right): https://codereview.chromium.org/16950008/diff/1/base/prefs/json_pref_store.cc#newcode161 base/prefs/json_pref_store.cc:161: read_error_(PREF_READ_ERROR_OTHER) {} On 2013/06/13 15:01:11, willchan wrote: > While ...
7 years, 6 months ago (2013-06-13 15:07:22 UTC) #3
willchan no longer on Chromium
I don't feel strongly, I <3 clang-format. Carry on good sir. On Jun 13, 2013 ...
7 years, 6 months ago (2013-06-13 15:16:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16950008/1
7 years, 6 months ago (2013-06-13 15:21:41 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 18:01:08 UTC) #6
Message was sent while issue was closed.
Change committed as 206116

Powered by Google App Engine
This is Rietveld 408576698