Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 1694383003: build: Bot_update refactor recipe roll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Disable for cronet and swarming Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 5688df42cab9751e269c5970983db1989c045944..c60637ef37d30b4268998df30f4123e4a5167a01 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -94,7 +94,7 @@ class AndroidApi(recipe_api.RecipeApi):
)
def init_and_sync(self, gclient_config='android_bare',
- with_branch_heads=False):
+ with_branch_heads=False, use_bot_update=True):
# TODO(sivachandra): Move the setting of the gclient spec below to an
# internal config extension when they are supported by the recipe system.
spec = self.m.gclient.make_config(gclient_config)
@@ -113,9 +113,10 @@ class AndroidApi(recipe_api.RecipeApi):
refs = self.m.properties.get('event.patchSet.ref')
if refs:
refs = [refs]
- result = self.m.bot_update.ensure_checkout(
- spec, refs=refs, with_branch_heads=with_branch_heads)
- if not result.json.output['did_run']:
+ if use_bot_update:
+ result = self.m.bot_update.ensure_checkout(
+ spec, refs=refs, with_branch_heads=with_branch_heads)
+ else:
result = self.m.gclient.checkout(spec, with_branch_heads=with_branch_heads)
# TODO(sivachandra): Manufacture gclient spec such that it contains "src"

Powered by Google App Engine
This is Rietveld 408576698