Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 16943018: Fix favicons in Other Devices page. (Closed)

Created:
7 years, 6 months ago by shashi
Modified:
7 years, 6 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Instead of using chrome://touch-icon for favicons this page should use chrome://session-favicon like other_devices.js. BUG=251818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208016

Patch Set 1 : Cleanup description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/ntp_android/ntp_android.js View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
shashi
tedchoc: owner and review. newt: fyi and thanks for the help.
7 years, 6 months ago (2013-06-21 22:22:08 UTC) #1
Ted C
lgtm
7 years, 6 months ago (2013-06-21 22:25:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/16943018/2001
7 years, 6 months ago (2013-06-21 22:29:17 UTC) #3
newt (away)
lgtm
7 years, 6 months ago (2013-06-21 22:35:29 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-22 01:12:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/16943018/2001
7 years, 6 months ago (2013-06-22 04:40:56 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 13:37:11 UTC) #7
Message was sent while issue was closed.
Change committed as 208016

Powered by Google App Engine
This is Rietveld 408576698