Issue 16943012: Make some additional adjustments to the v1 keyboard layout.

Issue 16943012: Make some additional adjustments to the v1 keyboard layout. (Closed)

Created:
7 years, 6 months ago by SteveT

Modified:
7 years, 6 months ago

Reviewers:
bryeung, bshe

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@reskin

Visibility:
Public.

More Reviews

Description

Make some additional adjustments to the v1 keyboard layout. Move the mic key to the capslock location. Remove the '@' key in favour of a second symbol key. Adjust the sizing of the space key. BUG=248226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207958

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix alignment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -20 lines)			Patch
	M	ui/keyboard/resources/keysets.html	View	1 2	8 chunks	+16 lines, -16 lines	0 comments	Download
	M	ui/keyboard/resources/main.css	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

SteveT

This change brings the layout and style up to date with the v1 mocks. PTAL. ...

7 years, 6 months ago (2013-06-21 16:52:30 UTC) #1

bshe

https://codereview.chromium.org/16943012/diff/1/ui/keyboard/resources/keysets.html File ui/keyboard/resources/keysets.html (right): https://codereview.chromium.org/16943012/diff/1/ui/keyboard/resources/keysets.html#newcode34 ui/keyboard/resources/keysets.html:34: <kb-key class="symbol dark" toKeyset="symbol" char="Invalid" align="left">#123</kb-key> From the mock, ...

7 years, 6 months ago (2013-06-21 16:58:42 UTC) #2

SteveT

PTAL. https://codereview.chromium.org/16943012/diff/1/ui/keyboard/resources/keysets.html File ui/keyboard/resources/keysets.html (right): https://codereview.chromium.org/16943012/diff/1/ui/keyboard/resources/keysets.html#newcode34 ui/keyboard/resources/keysets.html:34: <kb-key class="symbol dark" toKeyset="symbol" char="Invalid" align="left">#123</kb-key> Oops, yeah. ...

7 years, 6 months ago (2013-06-21 17:06:35 UTC) #3

bshe

On 2013/06/21 17:06:35, SteveT wrote: > PTAL. > > https://codereview.chromium.org/16943012/diff/1/ui/keyboard/resources/keysets.html > File ui/keyboard/resources/keysets.html (right): > ...

7 years, 6 months ago (2013-06-21 17:27:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/16943012/8001

7 years, 6 months ago (2013-06-21 17:43:19 UTC) #6

Message was sent while issue was closed.

Change committed as 207958

Expand Messages | Collapse Messages