Adds RefCountedDeleteOnMessageLoop

Adds RefCountedDeleteOnMessageLoop

RefCountedDeleteOnMessageLoop is similar to RefCountedThreadSafe, but guarantees that
the referenced object will be deleted on the specified loop.
The functionality is similar to content::DeleteOnThread<> but does not depend on
BrowserThread.

The CL includes an example use of the class.

BUG=248049
TBR=stuartmorgan, joth

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206445

[droger, 2013-06-13 17:19:26]

The context of this CL is a project to remove dependency of some components on
content/. To do that, we need an equivalent of content::DeleteOnThread<> that
does not use content/. This CL introduces RefCountedDeleteOnLoop which does
that.

Implementation notes:
I followed the pattern used by RefCountedThreadSafe and DeleteOnThread<>.
However, I am not sure why the implementation was done that way: in particular I
think both the static_cast and the template parameter could be avoided if the
destructor was made virtual. Maybe there are performance consideration involved?

[Mark Mentovai, 2013-06-13 18:36:33]

LGTM in base with these changes.

https://codereview.chromium.org/16938006/diff/13001/base/memory/ref_counted_d...
File base/memory/ref_counted_delete_on_message_loop.h (right):

https://codereview.chromium.org/16938006/diff/13001/base/memory/ref_counted_d...
base/memory/ref_counted_delete_on_message_loop.h:15: //
RefCountedDeleteOnMessageLoop is similar to RefCountedThreadSafe, and ensures
Fix the CL description to accurately reflect the name of this class.

https://codereview.chromium.org/16938006/diff/13001/base/memory/ref_counted_d...
base/memory/ref_counted_delete_on_message_loop.h:35: : public
base::subtle::RefCountedThreadSafeBase {
You don’t need to say base:: anywhere because you’re already in namespace base.
Applies throughout.

[Jói, 2013-06-13 22:51:51]

LGTM with Mark's comments addressed.

[droger, 2013-06-14 10:44:12]

TBR OWNERS:
joth: for android_webview/browser/aw_form_database_service.cc
stuartmorgan: for chrome/browser/password_manager/password_store_win_unittest.cc

[commit-bot: I haz the power, 2013-06-14 10:44:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/16938006/27001

[commit-bot: I haz the power, 2013-06-14 14:14:08]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-14 15:05:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/16938006/27001

[commit-bot: I haz the power, 2013-06-14 18:03:08]

Change committed as 206445