CPUProfiler: unflake flaky CPUProfiler tests.

test/cctest/test-cpu-profiler.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 902 matching lines @@
   GetChild(root, "start");
   // TODO(yurys): in CallIC should be changed to report external callback
   // invocation.
   // GetChild(startNode, "fooMethod");
 
   cpu_profiler->DeleteAllCpuProfiles();
 }
 
 
 static const char* cpu_profiler_sourceURL_source =
-"function start(timeout) {\n"
-"  var start = Date.now();\n"
-"  var duration = 0;\n"
-"  do {\n"
-"    try {\n"
-"      duration = Date.now() - start;\n"
-"    } catch(e) { }\n"
-"  } while (duration < timeout);\n"
-"  return duration;\n"
+"function start(warm_up) {\n"
+"  if (!warm_up) {\n"
+"    startProfiling();\n"
+"    stopProfiling();\n"
+"  }\n"
 "}\n"
 "//# sourceURL=cpu_profiler_sourceURL_source.js";
 
 
 TEST(SourceURLSupportForNewFunctions) {
-  LocalContext env;
-  v8::HandleScope scope(env->GetIsolate());
+  v8::Isolate* isolate = v8::Isolate::GetCurrent();
+  v8::HandleScope scope(isolate);
+  const char* extensions[] = { "v8/profiler" };
+  v8::ExtensionConfiguration config(1, extensions);
+  v8::Local<v8::Context> context = v8::Context::New(isolate, &config);

[yurys, 2013/06/13 09:11:35]

Can you continue using LocalContext for consistency? Note that its constructor
accepts v8::ExtensionConfiguration as first argument.

[loislo, 2013/06/13 10:01:42]

Done.

+  context->Enter();
 
   v8::Script::Compile(v8::String::New(cpu_profiler_sourceURL_source))->Run();
+  v8::Local<v8::Object> global = context->Global();
   v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
-      env->Global()->Get(v8::String::New("start")));
-  v8::CpuProfiler* cpu_profiler = env->GetIsolate()->GetCpuProfiler();
-  int32_t profiling_interval_ms = 100;
+      global->Get(v8::String::New("start")));
+  v8::CpuProfiler* cpu_profiler = isolate->GetCpuProfiler();
+  CHECK_NE(NULL, cpu_profiler);
+  CHECK_EQ(0, cpu_profiler->GetProfileCount());
 
   // Cold run.
-  v8::Local<v8::String> profile_name = v8::String::New("my_profile");
-  cpu_profiler->StartCpuProfiling(profile_name);
-  v8::Handle<v8::Value> args[] = { v8::Integer::New(profiling_interval_ms) };
-  function->Call(env->Global(), ARRAY_SIZE(args), args);
-  const v8::CpuProfile* profile = cpu_profiler->StopCpuProfiling(profile_name);
+  v8::Handle<v8::Value> args[] = { v8::Boolean::New(false) };
+  function->Call(global, ARRAY_SIZE(args), args);
+  CHECK_EQ(1, cpu_profiler->GetProfileCount());
+  const v8::CpuProfile* profile = cpu_profiler->GetCpuProfile(0);
   CHECK_NE(NULL, profile);
 
   // Dump collected profile to have a better diagnostic in case of failure.
   reinterpret_cast<i::CpuProfile*>(
       const_cast<v8::CpuProfile*>(profile))->Print();
   const v8::CpuProfileNode* root = profile->GetTopDownRoot();
   const v8::CpuProfileNode* startNode = GetChild(root, "start");
 
   CHECK_EQ(v8::String::New("cpu_profiler_sourceURL_source.js"),
            startNode->GetScriptResourceName());
 
   cpu_profiler->DeleteAllCpuProfiles();
 }
 
 TEST(LogExistingFunctionSourceURLCheck) {
-  LocalContext env;
-  v8::HandleScope scope(env->GetIsolate());
+  v8::Isolate* isolate = v8::Isolate::GetCurrent();
+  v8::HandleScope scope(isolate);
+  const char* extensions[] = { "v8/profiler" };
+  v8::ExtensionConfiguration config(1, extensions);
+  v8::Local<v8::Context> context = v8::Context::New(isolate, &config);

[yurys, 2013/06/13 09:11:35]

Ditto.

[loislo, 2013/06/13 10:01:42]

Done.

+  context->Enter();
 
   v8::Script::Compile(v8::String::New(cpu_profiler_sourceURL_source))->Run();
+  v8::Local<v8::Object> global = context->Global();
   v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
-      env->Global()->Get(v8::String::New("start")));
-  v8::CpuProfiler* cpu_profiler = env->GetIsolate()->GetCpuProfiler();
-  int32_t profiling_interval_ms = 100;
+      global->Get(v8::String::New("start")));
+  v8::CpuProfiler* cpu_profiler = isolate->GetCpuProfiler();
+  CHECK_NE(NULL, cpu_profiler);
+  CHECK_EQ(0, cpu_profiler->GetProfileCount());
 
   // Warm up.
-  v8::Handle<v8::Value> args[] = { v8::Integer::New(profiling_interval_ms) };
-  function->Call(env->Global(), ARRAY_SIZE(args), args);
+  v8::Handle<v8::Value> warm_up_args[] = { v8::Boolean::New(true) };
+  function->Call(global, ARRAY_SIZE(warm_up_args), warm_up_args);
+  CHECK_EQ(0, cpu_profiler->GetProfileCount());
 
-  v8::Local<v8::String> profile_name = v8::String::New("my_profile");
-  cpu_profiler->StartCpuProfiling(profile_name);
-  function->Call(env->Global(), ARRAY_SIZE(args), args);
-  const v8::CpuProfile* profile = cpu_profiler->StopCpuProfiling(profile_name);
+  // Run.
+  v8::Handle<v8::Value> args[] = { v8::Boolean::New(false) };
+  function->Call(global, ARRAY_SIZE(args), args);
+  CHECK_EQ(1, cpu_profiler->GetProfileCount());
+  const v8::CpuProfile* profile = cpu_profiler->GetCpuProfile(0);
   CHECK_NE(NULL, profile);
 
   // Dump collected profile to have a better diagnostic in case of failure.
   reinterpret_cast<i::CpuProfile*>(
       const_cast<v8::CpuProfile*>(profile))->Print();
   const v8::CpuProfileNode* root = profile->GetTopDownRoot();
   const v8::CpuProfileNode* startNode = GetChild(root, "start");
   CHECK_EQ(v8::String::New("cpu_profiler_sourceURL_source.js"),
            startNode->GetScriptResourceName());
 
   cpu_profiler->DeleteAllCpuProfiles();
 }