Source/core/inspector/InspectorInstrumentation.idl - Issue 16925002: XMLHttpRequest#responseText should use a rope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 16925002: XMLHttpRequest#responseText should use a rope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address reviewer feedback Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorInstrumentation.idl

diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl

index 0b8fe84ef4302f8538ee7f05d845dca2c32f3d17..bbf4d9c69818912dc5985e560c5d8f346e952c09 100644

--- a/Source/core/inspector/InspectorInstrumentation.idl

+++ b/Source/core/inspector/InspectorInstrumentation.idl

@@ -291,7 +291,7 @@ interface InspectorInstrumentation {

void didFailXHRLoading(ScriptExecutionContext*, ThreadableLoaderClient* client);

[Console, Resource]

- void didFinishXHRLoading(ScriptExecutionContext*, ThreadableLoaderClient* client, unsigned long identifier, const String& sourceString, const String& url, const String& sendURL, unsigned sendLineNumber);

+ void didFinishXHRLoading(ScriptExecutionContext*, ThreadableLoaderClient* client, unsigned long identifier, ScriptString sourceString, const String& url, const String& sendURL, unsigned sendLineNumber);

[Resource]

void didReceiveXHRResponse(ScriptExecutionContext*, unsigned long identifier);

« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.h ('k') | Source/core/inspector/InspectorResourceAgent.h » ('j') | no next file with comments »