XMLHttpRequest#responseText should use a rope

Source/core/xml/XMLHttpRequest.cpp

 /*
  *  Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *  Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
  *  Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
  *  Copyright (C) 2008, 2011 Google Inc. All rights reserved.
  *  Copyright (C) 2012 Intel Corporation
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Lesser General Public
  *  License as published by the Free Software Foundation; either
@@ skipping 196 matching lines @@
 SecurityOrigin* XMLHttpRequest::securityOrigin() const
 {
     return m_securityOrigin ? m_securityOrigin.get() : scriptExecutionContext()->securityOrigin();
 }
 
 XMLHttpRequest::State XMLHttpRequest::readyState() const
 {
     return m_state;
 }
 
-String XMLHttpRequest::responseText(ExceptionCode& ec)
+ScriptString XMLHttpRequest::responseText(ExceptionCode& ec)
 {
     if (m_responseTypeCode != ResponseTypeDefault && m_responseTypeCode != ResponseTypeText) {
         ec = INVALID_STATE_ERR;
-        return "";
+        return ScriptString();
     }
-    return m_responseBuilder.toStringPreserveCapacity();
+    return m_responseText;
 }
 
 Document* XMLHttpRequest::responseXML(ExceptionCode& ec)
 {
     if (m_responseTypeCode != ResponseTypeDefault && m_responseTypeCode != ResponseTypeDocument) {
         ec = INVALID_STATE_ERR;
         return 0;
     }
 
     if (m_error || m_state != DONE)
         return 0;
 
     if (!m_createdDocument) {
         bool isHTML = equalIgnoringCase(responseMIMEType(), "text/html");
 
         // The W3C spec requires the final MIME type to be some valid XML type, or text/html.
         // If it is text/html, then the responseType of "document" must have been supplied explicitly.
         if ((m_response.isHTTP() && !responseIsXML() && !isHTML)
             || (isHTML && m_responseTypeCode == ResponseTypeDefault)
             || scriptExecutionContext()->isWorkerContext()) {
             m_responseDocument = 0;
         } else {
             if (isHTML)
                 m_responseDocument = HTMLDocument::create(0, m_url);
             else
                 m_responseDocument = Document::create(0, m_url);
             // FIXME: Set Last-Modified.
-            m_responseDocument->setContent(m_responseBuilder.toStringPreserveCapacity());
+            m_responseDocument->setContent(m_responseText.flattenToString());
             m_responseDocument->setSecurityOrigin(securityOrigin());
             m_responseDocument->setContextFeatures(document()->contextFeatures());
             if (!m_responseDocument->wellFormed())
                 m_responseDocument = 0;
         }
         m_createdDocument = true;
     }
 
     return m_responseDocument.get();
 }
@@ skipping 577 matching lines @@
 }
 
 void XMLHttpRequest::clearResponse()
 {
     m_response = ResourceResponse();
     clearResponseBuffers();
 }
 
 void XMLHttpRequest::clearResponseBuffers()
 {
-    m_responseBuilder.clear();
+    m_responseText.clear();
     m_createdDocument = false;
     m_responseDocument = 0;
     m_responseBlob = 0;
     m_binaryResponseBuilder.clear();
     m_responseArrayBuffer.clear();
 }
 
 void XMLHttpRequest::clearRequest()
 {
     m_requestHeaders.clear();
@@ skipping 225 matching lines @@
 
 void XMLHttpRequest::didFinishLoading(unsigned long identifier, double)
 {
     if (m_error)
         return;
 
     if (m_state < HEADERS_RECEIVED)
         changeState(HEADERS_RECEIVED);
 
     if (m_decoder)
-        m_responseBuilder.append(m_decoder->flush());
+        m_responseText = m_responseText.concatenateWith(m_decoder->flush());
 
-    m_responseBuilder.shrinkToFit();
-
-    InspectorInstrumentation::didFinishXHRLoading(scriptExecutionContext(), this, identifier, m_responseBuilder.toStringPreserveCapacity(), m_url, m_lastSendURL, m_lastSendLineNumber);
+    InspectorInstrumentation::didFinishXHRLoading(scriptExecutionContext(), this, identifier, m_responseText, m_url, m_lastSendURL, m_lastSendLineNumber);
 
     bool hadLoader = m_loader;
     m_loader = 0;
 
     changeState(DONE);
     m_decoder = 0;
 
     if (hadLoader)
         dropProtection();
 }
@@ skipping 51 matching lines @@
             m_decoder = TextResourceDecoder::create("text/plain", "UTF-8");
     }
 
     if (!len)
         return;
 
     if (len == -1)
         len = strlen(data);
 
     if (useDecoder)
-        m_responseBuilder.append(m_decoder->decode(data, len));
+        m_responseText = m_responseText.concatenateWith(m_decoder->decode(data, len));
     else if (m_responseTypeCode == ResponseTypeArrayBuffer || m_responseTypeCode == ResponseTypeBlob) {
         // Buffer binary data.
         if (!m_binaryResponseBuilder)
             m_binaryResponseBuilder = SharedBuffer::create();
         m_binaryResponseBuilder->append(data, len);
     }
 
     if (!m_error) {
         long long expectedLength = m_response.expectedContentLength();
         m_receivedLength += len;
@@ skipping 97 matching lines @@
     info.addMember(m_url, "url");
     info.addMember(m_method, "method");
     info.addMember(m_requestHeaders, "requestHeaders");
     info.addMember(m_requestEntityBody, "requestEntityBody");
     info.addMember(m_mimeTypeOverride, "mimeTypeOverride");
     info.addMember(m_responseBlob, "responseBlob");
     info.addMember(m_loader, "loader");
     info.addMember(m_response, "response");
     info.addMember(m_responseEncoding, "responseEncoding");
     info.addMember(m_decoder, "decoder");
-    info.addMember(m_responseBuilder, "responseBuilder");
+    info.addMember(m_responseText, "responseText");
     info.addMember(m_responseDocument, "responseDocument");
     info.addMember(m_binaryResponseBuilder, "binaryResponseBuilder");
     info.addMember(m_responseArrayBuffer, "responseArrayBuffer");
     info.addMember(m_lastSendURL, "lastSendURL");
     info.addMember(m_eventTargetData, "eventTargetData");
     info.addMember(m_progressEventThrottle, "progressEventThrottle");
     info.addMember(m_securityOrigin, "securityOrigin");
 }
 
 } // namespace WebCore