Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 16922012: Enable GoDaddy/Starfield G2 roots for EV (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
Reviewers:
palmer, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Enable GoDaddy/Starfield G2 roots for EV BUG=246066 TEST=see test sites in CL. All should be marked EV on (Win, Linux, iOS, CrOS) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207288

Patch Set 1 #

Patch Set 2 : Fix policy oids #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M net/cert/ev_root_ca_metadata.cc View 1 2 chunks +18 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
Ryan Sleevi
palmer: For the stamp? See the EV policy spreadsheet for further details.
7 years, 6 months ago (2013-06-18 23:27:50 UTC) #1
palmer
lgtm
7 years, 6 months ago (2013-06-18 23:38:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16922012/2002
7 years, 6 months ago (2013-06-19 00:39:51 UTC) #3
Ryan Sleevi
Actually need a net/ OWNERS stamp for this. wtc, would you mind?
7 years, 6 months ago (2013-06-19 00:42:06 UTC) #4
wtc
LGTM. https://codereview.chromium.org/16922012/diff/2002/net/cert/ev_root_ca_metadata.cc File net/cert/ev_root_ca_metadata.cc (right): https://codereview.chromium.org/16922012/diff/2002/net/cert/ev_root_ca_metadata.cc#newcode292 net/cert/ev_root_ca_metadata.cc:292: // https://valid.sfsg2.catest.starfieldtech.com/ Just FYI: Firefox 21.0 on Linux ...
7 years, 6 months ago (2013-06-19 00:50:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16922012/2002
7 years, 6 months ago (2013-06-19 00:51:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=165552
7 years, 6 months ago (2013-06-19 05:43:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16922012/2002
7 years, 6 months ago (2013-06-19 17:15:35 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 02:58:52 UTC) #9
Message was sent while issue was closed.
Change committed as 207288

Powered by Google App Engine
This is Rietveld 408576698