Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 16922010: Rewrite scoped_ptr<T>(NULL) to use the default ctor in ui/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ui/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on CrOS in the ui/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M ui/oak/oak_window.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/controls/scrollbar/scrollbar_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
7 years, 6 months ago (2013-06-13 15:23:17 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-13 15:41:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16922010/1
7 years, 6 months ago (2013-06-13 15:47:44 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 00:23:59 UTC) #4
Message was sent while issue was closed.
Change committed as 206243

Powered by Google App Engine
This is Rietveld 408576698