Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 16917013: [CSS Grid Layout] CSSParser should reject <track-list> without a <track-size> (Closed)

Created:
7 years, 6 months ago by Julien - ping for review
Modified:
7 years, 6 months ago
Reviewers:
esprehn, darktears
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size> The case of <track-list> without a <track-size> was properly handled but that's because style resolution had to account for the parsing being not totally right. This refactoring will help with implementing parsing for <repeat-function> as the code matches the specification more closely. TEST=fast/css-grid-layout/named-grid-line-get-set.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 chunk +20 lines, -10 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
7 years, 6 months ago (2013-06-21 21:03:41 UTC) #1
darktears
On 2013/06/21 21:03:41, Julien Chaffraix wrote: lgtm
7 years, 6 months ago (2013-06-21 22:34:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/16917013/1
7 years, 6 months ago (2013-06-21 23:02:07 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 00:41:27 UTC) #4
Message was sent while issue was closed.
Change committed as 152914

Powered by Google App Engine
This is Rietveld 408576698