Issue 16911005: Fixing flaky ExtensionBrowsingDataTest.BrowsingDataRemovalMask test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16911005: Fixing flaky ExtensionBrowsingDataTest.BrowsingDataRemovalMask test. (Closed)

Created:
7 years, 6 months ago by dsinclair

Modified:
7 years, 6 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

From the stack trace, it appears that the ShaderClearHelper is getting cleaned up when the BackendIO object is destroyed. The BackendIO is holding a ref to the ShaderClearHelper, so there is a race between when BackendIO gets cleaned up and when we drop the ref ourselves. This CL moves the callback to hold a WeakRef to the ShaderClearHelper which should better handle the cleanup. We don't need to pass refs into the callback because we know the callback has executed by the time we drop the ref in the ShaderCacheFactory. BUG=251742 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207956

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	content/browser/gpu/shader_disk_cache.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/16911005/6001

7 years, 6 months ago (2013-06-21 18:42:07 UTC) #3

Message was sent while issue was closed.

Change committed as 207956

Expand Messages | Collapse Messages