Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1690453002: Mojom Parser: Populate |serialized_runimte_type_info| field during serialization. (Closed)

Created:
4 years, 10 months ago by rudominer
Modified:
4 years, 10 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom Parser: Populate |serialized_runimte_type_info| field during serialization. - We call FindReachableTypes() at serialization time. - This revealed a nil-pointer bug which we fix. BUG=#448 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/738df95a0d2290121d91a6711aada34a773b05b8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Protects access to global variables used in tests. #

Total comments: 4

Patch Set 3 : Rename variables and new sha1s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+754 lines, -30 lines) Patch
M mojo/public/tools/bindings/mojom_parser/bin/linux64/mojom_parser.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_parser/bin/mac64/mojom_parser.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/user_defined_types.go View 4 chunks +8 lines, -1 line 0 comments Download
M mojom/mojom_parser/parser/resolution_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 1 2 10 chunks +94 lines, -14 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 1 5 chunks +649 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
rudominer
Hi Alex, ptal.
4 years, 10 months ago (2016-02-11 00:30:47 UTC) #8
azani
https://codereview.chromium.org/1690453002/diff/100001/mojom/mojom_parser/serialization/serialization.go File mojom/mojom_parser/serialization/serialization.go (right): https://codereview.chromium.org/1690453002/diff/100001/mojom/mojom_parser/serialization/serialization.go#newcode26 mojom/mojom_parser/serialization/serialization.go:26: var EmitSerializedRuntimeTypeInfo bool = true As discussed, make this ...
4 years, 10 months ago (2016-02-11 19:45:48 UTC) #9
rudominer
ptal https://codereview.chromium.org/1690453002/diff/100001/mojom/mojom_parser/serialization/serialization.go File mojom/mojom_parser/serialization/serialization.go (right): https://codereview.chromium.org/1690453002/diff/100001/mojom/mojom_parser/serialization/serialization.go#newcode26 mojom/mojom_parser/serialization/serialization.go:26: var EmitSerializedRuntimeTypeInfo bool = true On 2016/02/11 19:45:48, ...
4 years, 10 months ago (2016-02-11 20:16:11 UTC) #10
azani
lgtm With just some naming issues. https://chromiumcodereview.appspot.com/1690453002/diff/120001/mojom/mojom_parser/serialization/serialization.go File mojom/mojom_parser/serialization/serialization.go (right): https://chromiumcodereview.appspot.com/1690453002/diff/120001/mojom/mojom_parser/serialization/serialization.go#newcode26 mojom/mojom_parser/serialization/serialization.go:26: var g_emitSerializedRuntimeTypeInfo bool ...
4 years, 10 months ago (2016-02-11 22:21:05 UTC) #11
rudominer
Committed patchset #3 (id:140001) manually as 738df95a0d2290121d91a6711aada34a773b05b8 (presubmit successful).
4 years, 10 months ago (2016-02-11 22:55:04 UTC) #13
rudominer
4 years, 10 months ago (2016-02-11 22:56:51 UTC) #14
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1690453002/diff/120001/mojom/mojom_par...
File mojom/mojom_parser/serialization/serialization.go (right):

https://chromiumcodereview.appspot.com/1690453002/diff/120001/mojom/mojom_par...
mojom/mojom_parser/serialization/serialization.go:26: var
g_emitSerializedRuntimeTypeInfo bool = true
On 2016/02/11 22:21:05, azani wrote:
> change the param name and change back to emitSerializeRuntimeTypeInfo to match
> go naming conventions.

Done.

https://chromiumcodereview.appspot.com/1690453002/diff/120001/mojom/mojom_par...
mojom/mojom_parser/serialization/serialization.go:47:
savEemitSerializedRuntimeTypeInfo := g_emitSerializedRuntimeTypeInfo
On 2016/02/11 22:21:05, azani wrote:
> saveEmit...

Done.

Powered by Google App Engine
This is Rietveld 408576698