Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: Source/modules/notifications/Notification.h

Issue 16904002: Avoid leaking objects between isolated worlds via attribute event listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/DOMWindow.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index 7717c668dcaecff5a1dbedea95309583418ced19..2b85a1dcc3185c8887935e4d57026943a6ec7a96 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -115,8 +115,7 @@ public:
TextDirection direction() const { return dir() == "rtl" ? RTL : LTR; }
#if ENABLE(LEGACY_NOTIFICATIONS)
- EventListener* ondisplay() { return getAttributeEventListener(eventNames().showEvent); }
- void setOndisplay(PassRefPtr<EventListener> listener) { setAttributeEventListener(eventNames().showEvent, listener); }
+ DEFINE_MAPPED_ATTRIBUTE_EVENT_LISTENER(display, show);
#endif
DEFINE_ATTRIBUTE_EVENT_LISTENER(show);
DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
« no previous file with comments | « Source/core/page/DOMWindow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698