Source/bindings/v8/V8AbstractEventListener.h - Issue 16904002: Avoid leaking objects between isolated worlds via attribute event listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8AbstractEventListener.h

Issue 16904002: Avoid leaking objects between isolated worlds via attribute event listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8AbstractEventListener.h

diff --git a/Source/bindings/v8/V8AbstractEventListener.h b/Source/bindings/v8/V8AbstractEventListener.h

index 0ed3dbc3848f278770f77f1a05e928c86628c844..6a2806d1ad97d88a33a4f46e51a5f1dc2ce3693e 100644

--- a/Source/bindings/v8/V8AbstractEventListener.h

+++ b/Source/bindings/v8/V8AbstractEventListener.h

@@ -109,7 +109,7 @@ namespace WebCore {

m_listener.clear();

}

- DOMWrapperWorld* world() const { return m_world.get(); }

+ virtual DOMWrapperWorld* world() const OVERRIDE FINAL { return m_world.get(); }

protected:

V8AbstractEventListener(bool isAttribute, PassRefPtr<DOMWrapperWorld>, v8::Isolate*);

« no previous file with comments | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »