ui/base/ime/input_method_tsf.cc - Issue 16901011: Support CancelCompositionText/ComfirmCompositionText in TSF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_tsf.cc

Issue 16901011: Support CancelCompositionText/ComfirmCompositionText in TSF (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix a typo Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/input_method_tsf.cc

diff --git a/ui/base/ime/input_method_tsf.cc b/ui/base/ime/input_method_tsf.cc

index ab720f11da4a6600dced99fdf7eafba0f9b5c80c..6980eecbfd1939353a4ee8b47791ca41363ba40a 100644

--- a/ui/base/ime/input_method_tsf.cc

+++ b/ui/base/ime/input_method_tsf.cc

@@ -123,12 +123,8 @@ void InputMethodTSF::OnDidChangeFocusedClient(TextInputClient* focused_before,

}

void InputMethodTSF::ConfirmCompositionText() {

- if (!IsTextInputTypeNone()) {

- // TSFBridge has not implemented ConfirmComposition yet. So here cancel

- // the composition instead as a workaround.

- // TODO(ime): Implement ConfirmComposition for TSF.

- ui::TSFBridge::GetInstance()->CancelComposition();

- }

+ if (!IsTextInputTypeNone())

+ ui::TSFBridge::GetInstance()->ConfirmComposition();

}

bool InputMethodTSF::IsWindowFocused(const TextInputClient* client) const {

« no previous file with comments | « no previous file | ui/base/ime/win/mock_tsf_bridge.h » ('j') | no next file with comments »