Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: tests/standalone/standalone.status

Issue 1688423002: Fix status files to account for dart_product runtime. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/standalone.status
diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status
index 43cd0bc3634f14130afccf9883a5e708c55d6cb8..b3d20f57965cd4451642f80aeaba41bd228b1e0a 100644
--- a/tests/standalone/standalone.status
+++ b/tests/standalone/standalone.status
@@ -21,12 +21,12 @@ issue14236_test: Pass # Do not remove this line. It serves as a marker for Issue
[ ($runtime != vm && $runtime != dart_precompiled) && ($runtime != drt || $compiler != none)) ]
no_assert_test: Fail, OK # This is testing a vm flag.
-[ ($runtime == vm || $runtime == dart_precompiled) ]
+[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
package/package_isolate_test: Fail # Issue 12474
io/observatory_test: Fail
package/scenarios/invalid/same_package_twice_test: Pass # Issue 24119
-[ ($runtime == vm || $runtime == dart_precompiled) && $checked ]
+[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $checked ]
# These tests have type errors on purpose.
io/process_invalid_arguments_test: Fail, OK
io/directory_invalid_arguments_test: Fail, OK
@@ -39,7 +39,7 @@ io/stdout_bad_argument_test: Fail, OK
io/file_fuzz_test: Skip
io/directory_fuzz_test: Skip
-[ ($runtime == vm || $runtime == dart_precompiled) && $system == macos ]
+[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $system == macos ]
# This test fails with "Too many open files" on the Mac OS buildbot.
# This is expected as MacOS by default runs with a very low number
# of allowed open files ('ulimit -n' says something like 256).
@@ -53,7 +53,7 @@ io/http_proxy_test: Skip
io/secure_builtin_roots_test: Skip
-[ ($compiler == none || $compiler == precompiler) && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) ]
+[ $compiler == none && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) ]
typed_array_test: RuntimeError, OK # Uses Isolate.spawn
typed_array_int64_uint64_test: RuntimeError, OK # Uses Isolate.spawn
typed_data_isolate_test: SkipByDesign # This test uses dart:io
@@ -111,19 +111,19 @@ precompilation_dart2js_test: Skip # Standalone only test.
noopt_test: Skip # Standalone only test.
regress_25335_test: Skip # Int64List not supported.
-[ $runtime == vm && $mode == debug ]
+[ ($runtime == vm || $runtime == dart_product) && $mode == debug ]
precompilation_dart2js_test: Pass, Slow
-[ $runtime == vm && $arch == ia32 ]
+[ ($runtime == vm || $runtime == dart_product) && $arch == ia32 ]
precompilation_test: Skip # Not expected to pass on ia32.
precompilation_dart2js_test: Skip # Not expected to pass on ia32.
noopt_test: Skip # Not expected to pass on ia32.
-[ $runtime == vm && $arch == arm ]
+[ ($runtime == vm || $runtime == dart_product) && $arch == arm ]
precompilation_test: Skip # Issue 24427
precompilation_dart2js_test: Skip # Issue 24427
-[ $runtime == vm && $arch == mips ]
+[ ($runtime == vm || $runtime == dart_product) && $arch == mips ]
precompilation_dart2js_test: SkipSlow
[ $compiler == dart2js && $jscl ]
@@ -158,7 +158,7 @@ io/test_runner_test: Skip # Flakily times out in a subtest. Issue 201351
full_coverage_test: SkipSlow # Times out. Issue 20352
io/http_client_stays_alive_test: Skip # Timing dependent test, MIPS machine too slow.
-[ ($compiler == none || $compiler == precompiler) && ($runtime == dartium || $runtime == ContentShellOnAndroid) && $unchecked ]
+[ $compiler == none && ($runtime == dartium || $runtime == ContentShellOnAndroid) && $unchecked ]
assert_test: Fail # Issue 14651.
[ $compiler == none && $runtime == drt ]
@@ -201,13 +201,13 @@ io/sleep_test: Pass, Fail # Issue 25757
[ $arch != ia32 && $arch != x64 && $arch != simarm && $arch != simarmv5te && $mode == debug ]
verified_mem_test: Skip # Not yet implemented.
-[ ($runtime == vm || $runtime == dart_precompiled) && $mode == debug && $builder_tag == asan ]
+[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $mode == debug && $builder_tag == asan ]
full_coverage_test: Skip # Timeout.
io/file_lock_test: Skip # Timeout.
io/test_runner_test: Skip # Timeout.
io/http_client_stays_alive_test: Skip # Timeout.
-[ ($runtime == vm || $runtime == dart_precompiled) ]
+[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
# Failures in secure networking while NSS is replaced with BoringSSL
io/https_client_certificate_test: RuntimeError # Issue 24070
io/secure_socket_renegotiate_test: RuntimeError

Powered by Google App Engine
This is Rietveld 408576698