Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: gpu/command_buffer/tests/es3_misc_functions_unittest.cc

Issue 1688163002: command_buffer: Implement glGetStringi for GL ES 3.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@command-buffer-generator-int-types
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/es3_misc_functions_unittest.cc
diff --git a/gpu/command_buffer/tests/es3_misc_functions_unittest.cc b/gpu/command_buffer/tests/es3_misc_functions_unittest.cc
index 6b3ffa96accc76ca7ffb7358a5a00da3c53d9546..634bf1de8f3afeb3dd0191d7171883bc2b07c0ff 100644
--- a/gpu/command_buffer/tests/es3_misc_functions_unittest.cc
+++ b/gpu/command_buffer/tests/es3_misc_functions_unittest.cc
@@ -8,6 +8,7 @@
#include <GLES3/gl3.h>
#include "base/command_line.h"
+#include "base/strings/string_split.h"
#include "gpu/command_buffer/tests/gl_manager.h"
#include "gpu/command_buffer/tests/gl_test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -87,4 +88,26 @@ TEST_F(OpenGLES3FunctionTest, MAYBE_GetFragDataLocationInvalid) {
glDeleteProgram(program);
}
+TEST_F(OpenGLES3FunctionTest, GetStringiTest) {
+ if (!IsApplicable()) {
+ return;
+ }
+ std::string extensionString =
+ reinterpret_cast<const char*>(glGetString(GL_EXTENSIONS));
+ std::vector<std::string> extensions =
+ base::SplitString(extensionString, base::kWhitespaceASCII,
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
+ int num_extensions = 0;
+ glGetIntegerv(GL_NUM_EXTENSIONS, &num_extensions);
+ EXPECT_EQ(extensions.size(), static_cast<size_t>(num_extensions));
+ std::set<std::string> extensions_from_string(extensions.begin(),
+ extensions.end());
+ std::set<std::string> extensions_from_stringi;
+ for (int i = 0; i < num_extensions; ++i) {
+ extensions_from_stringi.insert(
+ reinterpret_cast<const char*>(glGetStringi(GL_EXTENSIONS, i)));
+ }
+ EXPECT_EQ(extensions_from_string, extensions_from_stringi);
+}
+
} // namespace gpu

Powered by Google App Engine
This is Rietveld 408576698