Use toElement instead of static_cast<Element*> and static_cast<const Element*>

Use toElement instead of static_cast<Element*> and static_cast<const Element*>

toElement is already used in many places, however, there are still exist
static_cast<Element*> and static_cast<const Element*>. This CL replaces
these static_cast with toElement.

BUG=none
TEST=none; no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152922

[yoshinori.sano, 2013-06-22 01:07:55]

Could you review this patch?
Thanks in advance.

https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
Source/core/editing/ReplaceSelectionCommand.cpp:101: return node &&
node->hasTagName(brTag) && toElement(node)->getAttribute(classAttr) ==
interchangeNewlineClassString;
Reluctantly combined them because I got the following error.
Is there a more preferable way to fix it?

** Presubmit ERRORS **
check-webkit-style failed
  Source/core/editing/ReplaceSelectionCommand.cpp:102:  Weird number of spaces
at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 7 files

[abarth-chromium, 2013-06-22 06:45:02]

lgtm

https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
Source/core/editing/ReplaceSelectionCommand.cpp:101: return node &&
node->hasTagName(brTag) && toElement(node)->getAttribute(classAttr) ==
interchangeNewlineClassString;
That's fine.

[commit-bot: I haz the power, 2013-06-22 06:45:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/16879016/1

[commit-bot: I haz the power, 2013-06-22 06:45:11]

Failed to apply patch for Source/core/dom/Element.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Element.h
  Hunk #1 FAILED at 771.
  Hunk #2 FAILED at 779.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/core/dom/Element.h.rej

Patch:       Source/core/dom/Element.h
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index
fed0c42974aaf22d8eacbf157517addd31b22a08..980aa17f63a3fe82c0dbb8529350797ed5efd427
100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -771,7 +771,7 @@ inline Element* Node::previousElementSibling() const
     Node* n = previousSibling();
     while (n && !n->isElementNode())
         n = n->previousSibling();
-    return static_cast<Element*>(n);
+    return toElement(n);
 }
 
 inline Element* Node::nextElementSibling() const
@@ -779,7 +779,7 @@ inline Element* Node::nextElementSibling() const
     Node* n = nextSibling();
     while (n && !n->isElementNode())
         n = n->nextSibling();
-    return static_cast<Element*>(n);
+    return toElement(n);
 }
 
 inline bool Element::fastHasAttribute(const QualifiedName& name) const

[yoshinori.sano, 2013-06-22 08:06:05]

On 2013/06/22 06:45:02, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
> File Source/core/editing/ReplaceSelectionCommand.cpp (right):
> 
>
https://codereview.chromium.org/16879016/diff/1/Source/core/editing/ReplaceSe...
> Source/core/editing/ReplaceSelectionCommand.cpp:101: return node &&
> node->hasTagName(brTag) && toElement(node)->getAttribute(classAttr) ==
> interchangeNewlineClassString;
> That's fine.

Copy that :)

[commit-bot: I haz the power, 2013-06-22 08:07:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/16879016/5001

[yoshinori.sano, 2013-06-22 08:13:43]

NOTE: static_cast<Element*> in core/dom/Element.h had been replaced with
toElement before the Patch Set 1:
https://chromiumcodereview.appspot.com/17094020

[commit-bot: I haz the power, 2013-06-22 09:27:47]

Change committed as 152922