Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 16879013: Use chromium logic for database identifier<->origin conversions (Closed)

Created:
7 years, 6 months ago by jamesr
Modified:
7 years, 6 months ago
Reviewers:
michaeln, Nico, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dgrogan, alecflett, jsbell, abarth-chromium
Visibility:
Public.

Description

Use chromium logic for database identifier<->origin conversions This switches over to using the logic added in r206815 for database id / origin identification instead of WebSecurityOrigin. I'll delete the old code after this has landed. BUG=243095 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207191

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : remove webkit/base/origin_url_conversions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -142 lines) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 2 5 chunks +14 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/base/origin_url_conversions.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M webkit/base/origin_url_conversions.cc View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M webkit/base/webkit_base.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/browser/database/database_quota_client.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/database/database_quota_client_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 2 8 chunks +12 lines, -12 lines 0 comments Download
M webkit/browser/database/database_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/database/database_util_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 2 8 chunks +7 lines, -7 lines 0 comments Download
M webkit/common/database/database_identifier.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/common/database/database_identifier.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M webkit/common/database/database_identifier_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
Michael - please review. I've run content_unittests / content_browsertests with a version of this patch ...
7 years, 6 months ago (2013-06-18 21:37:49 UTC) #1
jamesr
Fixing title
7 years, 6 months ago (2013-06-18 21:38:14 UTC) #2
jsbell
https://codereview.chromium.org/16879013/diff/3001/content/browser/indexed_db/indexed_db_context_impl.cc File content/browser/indexed_db/indexed_db_context_impl.cc (right): https://codereview.chromium.org/16879013/diff/3001/content/browser/indexed_db/indexed_db_context_impl.cc#newcode37 content/browser/indexed_db/indexed_db_context_impl.cc:37: FILE_PATH_LITERAL(".indexeddb"); FYI, these string constants are duplicated in indexed_db_backing_store.cc ...
7 years, 6 months ago (2013-06-18 21:49:50 UTC) #3
michaeln
lgtm
7 years, 6 months ago (2013-06-18 23:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16879013/14001
7 years, 6 months ago (2013-06-18 23:29:12 UTC) #5
jamesr
TBR'ing thakis for chrome/browser/extensions/extension_service_unittest.cc and content/browser/renderer_host/database_message_filter.cc since this is an API change with owners approval
7 years, 6 months ago (2013-06-18 23:39:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16879013/14001
7 years, 6 months ago (2013-06-18 23:40:17 UTC) #7
commit-bot: I haz the power
Change committed as 207191
7 years, 6 months ago (2013-06-19 06:19:37 UTC) #8
Nico
7 years, 6 months ago (2013-06-19 18:28:24 UTC) #9
Message was sent while issue was closed.
On 2013/06/18 23:39:53, jamesr wrote:
> TBR'ing thakis for chrome/browser/extensions/extension_service_unittest.cc and
> content/browser/renderer_host/database_message_filter.cc since this is an API
> change with owners approval

lgtm

That's cool, but somehow I didn't receive this message. The first message I got
from this thread was the "CQ is trying da patch" message, which isn't very
informative.

Powered by Google App Engine
This is Rietveld 408576698