Updating JSON Schema Compiler to add description field to schemas.

Add descriptions to all extension/app schemas, and enforce that they have them
from now on.

BUG=233968
R=kalman@chromium.org
TBR=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208110

[epeterson, 2013-06-13 03:24:27]

Here's a patch related to the JSON schema compiler changes: specifically, adding
a description field to API schemas for use in the intro-tables.

I went through each of these files and checked over the descriptions. Fixed one
or two typo's along the way, and left some general comments.

This may be more of a tech. writing-centered patch, so I'm adding Meggin to the
reviewers list.


Thanks,
Evan

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/cookies.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/cookies.json:8: "description": "The
<code>chrome.cookies</code> module allows you to work with HTTP cookies.",
This isn't an official description, I just made it up.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/dial.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/dial.idl:31: // refresh the menu when it is
displayed.
All of this is going to show up as dial's description. It's full of great
information, but we probably want to move this somewhere else and leave a more
concise description here.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/experimental_system_info_storage.idl:4: 
No description currently.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/i18n.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/i18n.json:8: "description": "With the
<code>chrome.i18n</code> module, an <em>internationalized</em> extension or app
can be easily <em>localized</em> &mdash; adapted to languages and regions that
it didn't originally support.",
I modified this description a little bit, to include the typical <code></code>
module stuff.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/location.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/location.idl:4: // TODO(vadimt): Consider reusing
WebKit/Blink types, if this is possible.
Moved this up so that we can keep the comment without the schema compiler
reading it as a description.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/location.idl:5: 
Also, there is no description for the location schema

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/media_galleries_private.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/media_galleries_private.idl:6: //
systeminfo.storage API in M24.
This description is outdated.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/system_info_cpu.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/system_info_cpu.idl:4: 
No official description for system_info_cpu

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/tab_capture.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/tab_capture.idl:6: // streams.
Added some tech-writing flair.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/usb.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/usb.idl:7: // of an app. Using this API, apps can
function as drivers for hardware devices.
The descriptions switch between using the term 'module' and using the term
'API.' It looks like module may be the newer, preferred term; however, here,
both are used. Should this be standardized while we're adding in all these
descriptions?

[not at google - send to devlin, 2013-06-19 16:47:16]

Awesome, thanks for doing this. I didn't look at every description, only the
ones you pointed out, but I presume they're just copied from the intros. I'll
have a glance at everything when these comments are addressed.

Note the one about module -> API.

Incidentally I'd love to see a presubmit check here that APIs have descriptions.
You'd need to actually parse the schema into the model and then assert it
(rather than trying some hacky string matching thing) and for that - well -
Python might be a pain. And good luck figuring out presubmit checks :\ but it
would be really great. Things won't regress then and look silly.

How about you give it an hour or so of your time. If it takes any longer then
submit this and then go back to working on it, so that it won't rot.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/cookies.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/cookies.json:8: "description": "The
<code>chrome.cookies</code> module allows you to work with HTTP cookies.",
On 2013/06/13 03:24:28, epeterson wrote:
> This isn't an official description, I just made it up.

How about: Use the <code>chrome.cookies</code> API to query and modify cookies,
and be notified when they change.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/dial.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/dial.idl:31: // refresh the menu when it is
displayed.
On 2013/06/13 03:24:28, epeterson wrote:
> All of this is going to show up as dial's description. It's full of great
> information, but we probably want to move this somewhere else and leave a more
> concise description here.

Yes we should move it to an intro. Could you do that?

You could use the first paragraph here as the description, re-worded to sound
like the others. "Use the <code>chrome.dial</code> API to discover devices that
support DIAL".

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/experimental_system_info_storage.idl:4: 
On 2013/06/13 03:24:28, epeterson wrote:
> No description currently.

Yeah. Let's put something.

Use the <code>chrome.experimental.systemInfo.storage</code> API to query storage
device information and be notified when it changes.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/i18n.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/i18n.json:8: "description": "With the
<code>chrome.i18n</code> module, an <em>internationalized</em> extension or app
can be easily <em>localized</em> &mdash; adapted to languages and regions that
it didn't originally support.",
On 2013/06/13 03:24:28, epeterson wrote:
> I modified this description a little bit, to include the typical <code></code>
> module stuff.

Could you also re-word it like the others? It's a bit strange here since the
page its on describes the whole i18n infrastructure, not just the API. In any
case this description has too many commas.

Use the <code>chrome.i18n</code> infrastructure to implement
internationalization across your whole app or extension.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/location.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/location.idl:5: 
On 2013/06/13 03:24:28, epeterson wrote:
> Also, there is no description for the location schema

How about:

The <code>chrome.location</code> API augments the events from the <a
href="http://dev.w3.org/geo/api/spec-source.html">HTML Geolocation API</a> to be
event page compatible.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/media_galleries_private.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/media_galleries_private.idl:6: //
systeminfo.storage API in M24.
On 2013/06/13 03:24:28, epeterson wrote:
> This description is outdated.

Meh, it's a private API anyway. We should nevertheless file a bug on it.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/system_info_cpu.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/system_info_cpu.idl:4: 
On 2013/06/13 03:24:28, epeterson wrote:
> No official description for system_info_cpu

Use the <code>systemInfo.cpu</code> API to query CPU metadata.

dunno. it sounds like a useless API anyway.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/tab_capture.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/tab_capture.idl:6: // streams.
On 2013/06/13 03:24:28, epeterson wrote:
> Added some tech-writing flair.

sweet

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/usb.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/usb.idl:7: // of an app. Using this API, apps can
function as drivers for hardware devices.
On 2013/06/13 03:24:28, epeterson wrote:
> The descriptions switch between using the term 'module' and using the term
> 'API.' It looks like module may be the newer, preferred term; however, here,
> both are used. Should this be standardized while we're adding in all these
> descriptions?

Use API. Ugh. Ok can you replace "module" with "API" everywhere? the phrase
"module" is really an implementation detail of the API.

[epeterson, 2013-06-20 23:07:40]

Here's a few changes, mostly updates to the descriptions for a few APIs, and an
HTML intro for chrome.dial has been added.

I've looked at the presubmit checks, and I'll try and get a check for schemas
having a description, although that isn't included in this patchset.

Also, before this is committed, I believe the middle number in app.yaml needs to
be bumped.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/cookies.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/cookies.json:8: "description": "The
<code>chrome.cookies</code> module allows you to work with HTTP cookies.",
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > This isn't an official description, I just made it up.
> 
> How about: Use the <code>chrome.cookies</code> API to query and modify
cookies,
> and be notified when they change.

Done.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/dial.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/dial.idl:31: // refresh the menu when it is
displayed.
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > All of this is going to show up as dial's description. It's full of great
> > information, but we probably want to move this somewhere else and leave a
more
> > concise description here.
> 
> Yes we should move it to an intro. Could you do that?
> 
> You could use the first paragraph here as the description, re-worded to sound
> like the others. "Use the <code>chrome.dial</code> API to discover devices
that
> support DIAL".

I created an intro for chrome.dial. The API isn't currently listed in the
available APIs for extensions or apps, though, so I didn't add in a public
template for it.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/experimental_system_info_storage.idl:4: 
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > No description currently.
> 
> Yeah. Let's put something.
> 
> Use the <code>chrome.experimental.systemInfo.storage</code> API to query
storage
> device information and be notified when it changes.

Done.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/i18n.json (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/i18n.json:8: "description": "With the
<code>chrome.i18n</code> module, an <em>internationalized</em> extension or app
can be easily <em>localized</em> &mdash; adapted to languages and regions that
it didn't originally support.",
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > I modified this description a little bit, to include the typical
<code></code>
> > module stuff.
> 
> Could you also re-word it like the others? It's a bit strange here since the
> page its on describes the whole i18n infrastructure, not just the API. In any
> case this description has too many commas.
> 
> Use the <code>chrome.i18n</code> infrastructure to implement
> internationalization across your whole app or extension.

Done.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/location.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/location.idl:5: 
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > Also, there is no description for the location schema
> 
> How about:
> 
> The <code>chrome.location</code> API augments the events from the <a
> href="http://dev.w3.org/geo/api/spec-source.html">HTML Geolocation API</a> to
be
> event page compatible.

Done.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/media_galleries_private.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/media_galleries_private.idl:6: //
systeminfo.storage API in M24.
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > This description is outdated.
> 
> Meh, it's a private API anyway. We should nevertheless file a bug on it.

Done. Here's a link to the issue:
https://code.google.com/p/chromium/issues/detail?id=252048

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/system_info_cpu.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/system_info_cpu.idl:4: 
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > No official description for system_info_cpu
> 
> Use the <code>systemInfo.cpu</code> API to query CPU metadata.
> 
> dunno. it sounds like a useless API anyway.

Done.

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/usb.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/usb.idl:7: // of an app. Using this API, apps can
function as drivers for hardware devices.
On 2013/06/19 16:47:16, kalman wrote:
> On 2013/06/13 03:24:28, epeterson wrote:
> > The descriptions switch between using the term 'module' and using the term
> > 'API.' It looks like module may be the newer, preferred term; however, here,
> > both are used. Should this be standardized while we're adding in all these
> > descriptions?
> 
> Use API. Ugh. Ok can you replace "module" with "API" everywhere? the phrase
> "module" is really an implementation detail of the API.

Done for the schemas. I'll change the references to "module" in the HTML intros
as well, but that'll happen when I upload a CL with the intros that have already
been modified as a part of the larger patch.

https://codereview.chromium.org/16876004/diff/19001/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/intros/dial.html (right):

https://codereview.chromium.org/16876004/diff/19001/chrome/common/extensions/...
chrome/common/extensions/docs/templates/intros/dial.html:30: refresh the menu
when it is displayed.</p>
Here's the chrome.dial intro.
I added a public template for dial so that I could look at the HTML here, but
then removed it since it hadn't been there before.
I guess the world just isn't ready for dial yet.

[not at google - send to devlin, 2013-06-21 00:23:40]

Quick reply here before I look at the code again.

> I've looked at the presubmit checks, and I'll try and get a check for schemas
> having a description, although that isn't included in this patchset.

I don't mind if you do this later. It's possible that something would already
pick it up actually. What happens if you try to upload one without a
description? I would hope that the integration tests run and pick it up.

> 
> Also, before this is committed, I believe the middle number in app.yaml needs
to
> be bumped.
> 

Yep.

[not at google - send to devlin, 2013-06-21 00:30:55]

lgtm with some small other changes. if those are pretty straightforward, let's
submit!

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/media_galleries_private.idl (right):

https://codereview.chromium.org/16876004/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/media_galleries_private.idl:6: //
systeminfo.storage API in M24.
On 2013/06/20 23:07:40, epeterson wrote:
> On 2013/06/19 16:47:16, kalman wrote:
> > On 2013/06/13 03:24:28, epeterson wrote:
> > > This description is outdated.
> > 
> > Meh, it's a private API anyway. We should nevertheless file a bug on it.
> 
> Done. Here's a link to the issue:
> https://code.google.com/p/chromium/issues/detail?id=252048

Cool, link to that in the comment.

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:313: description=None):
let's make this compulsory

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:370: namespace = Namespace(node, nodoc,
internal, description)
let's add here:

if not description:
  raise ValueError(node.GetName() + ' must have a namespace-level comment ' +
                   'This will appear on the API summary page.')

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:378: if description == '':
condition not necessary with above logic

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
File tools/json_schema_compiler/model.py (right):

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/model.py:58: self.description =
json.get('description', None)
So yeah, let's try making the description compulsory.

if 'description' not in json:
  raise ValueError(name + ' must have a "description" field. ' +
                   'This will appear on the API summary page.')

[epeterson, 2013-06-21 20:10:15]

API schema descriptions are now mandatory.
Unfortunately, the amount of files touched by this CL has grown a lot. I had to
change just about all of the test files used in the json_schema_compiler
directory, as well as a good number of experimental/private files in the api
directory.

I've left a comment on descriptions where I made something up because I couldn't
find any pre-existing description.

If this still looks all good to you, I'll bump the app.yaml version and check
the commit box.

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:313: description=None):
On 2013/06/21 00:30:55, kalman wrote:
> let's make this compulsory

Done.

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:370: namespace = Namespace(node, nodoc,
internal, description)
On 2013/06/21 00:30:55, kalman wrote:
> let's add here:
> 
> if not description:
>   raise ValueError(node.GetName() + ' must have a namespace-level comment ' +
>                    'This will appear on the API summary page.')

Done.

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/idl_schema.py:378: if description == '':
On 2013/06/21 00:30:55, kalman wrote:
> condition not necessary with above logic 

Done.

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
File tools/json_schema_compiler/model.py (right):

https://codereview.chromium.org/16876004/diff/19001/tools/json_schema_compile...
tools/json_schema_compiler/model.py:58: self.description =
json.get('description', None)
On 2013/06/21 00:30:55, kalman wrote:
> So yeah, let's try making the description compulsory.
> 
> if 'description' not in json:
>   raise ValueError(name + ' must have a "description" field. ' +
>                    'This will appear on the API summary page.')

Done.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/experimental_identity.idl (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_identity.idl:5: // The
<code>chrome.experimental.identity</code> API.
lame description.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/experimental_media_galleries.idl (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_media_galleries.idl:6: // API's
functionality.
Yep, this one probably needs an official description.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/experimental_record.json (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_record.json:4: "description": "The
<code>chrome.experimental.record</code> API.",
Couldn't really figure out the the API was for..

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/feedback_private.idl:5: // A private API for
accessing feedback reports sent by a user.
Made this one up.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/script_badge.json (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/script_badge.json:8: "description": "Use the
<code>chrome.scriptBadge</code> API to inject an icon into the browser that will
open an HTML popup when clicked.",
Probably want to quality-check this one.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/session_restore.json (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/session_restore.json:8: "description": "Use the
<code>chrome.sessionRestore</code> API to open up previously closed tabs upon
startup of a new browser session.",
Also wrote this one.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/system_info_display.idl (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/system_info_display.idl:5: // Use the
<code>systemInfo.display</code> API to query display metadata.
Copied the idea of systemInfo.cpu's description here.

[not at google - send to devlin, 2013-06-21 20:58:51]

lgtm. bump app yaml and commit!

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/script_badge.json (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/script_badge.json:8: "description": "Use the
<code>chrome.scriptBadge</code> API to inject an icon into the browser that will
open an HTML popup when clicked.",
On 2013/06/21 20:10:15, epeterson wrote:
> Probably want to quality-check this one.

Yeah the API is defunct anyway. But:

Use the <code>..</code> API to control the behaviour of the script badge.

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
File chrome/common/extensions/api/session_restore.json (right):

https://codereview.chromium.org/16876004/diff/33001/chrome/common/extensions/...
chrome/common/extensions/api/session_restore.json:8: "description": "Use the
<code>chrome.sessionRestore</code> API to open up previously closed tabs upon
startup of a new browser session.",
On 2013/06/21 20:10:15, epeterson wrote:
> Also wrote this one.

Almost right:

Use the ... API to query and restore tabs and windows from a browsing session.

[commit-bot: I haz the power, 2013-06-21 23:36:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/48001

[commit-bot: I haz the power, 2013-06-22 00:03:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-22 01:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65001

[commit-bot: I haz the power, 2013-06-22 02:31:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65001

[commit-bot: I haz the power, 2013-06-22 02:56:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-22 15:35:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65001

[commit-bot: I haz the power, 2013-06-22 15:39:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-22 15:41:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65001

[commit-bot: I haz the power, 2013-06-22 15:44:21]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-22 16:12:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65005

[commit-bot: I haz the power, 2013-06-22 16:27:56]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-22 16:33:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/65005

[commit-bot: I haz the power, 2013-06-22 19:54:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/74003

[commit-bot: I haz the power, 2013-06-22 19:54:41]

Failed to apply patch for chrome/common/extensions/docs/server2/app.yaml:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/common/extensions/docs/server2/app.yaml
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/extensions/docs/server2/app.yaml.rej

Patch:       chrome/common/extensions/docs/server2/app.yaml
Index: chrome/common/extensions/docs/server2/app.yaml
diff --git a/chrome/common/extensions/docs/server2/app.yaml
b/chrome/common/extensions/docs/server2/app.yaml
index
35c406ba0e4c2512950774b9e99fbc3fe8d2bda9..b271d550496257cfd5d936aa647679f372d04735
100644
--- a/chrome/common/extensions/docs/server2/app.yaml
+++ b/chrome/common/extensions/docs/server2/app.yaml
@@ -1,5 +1,5 @@
 application: chrome-apps-doc
-version: 2-7-1
+version: 2-8-1
 runtime: python27
 api_version: 1
 threadsafe: false

[commit-bot: I haz the power, 2013-06-22 21:42:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/38008

[commit-bot: I haz the power, 2013-06-23 00:00:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/16876004/38008

[commit-bot: I haz the power, 2013-06-23 04:25:00]

Change committed as 208110