Issue 16875007: [Downloads] Remove RDH from DownloadUrlParameters.

Issue 16875007: [Downloads] Remove RDH from DownloadUrlParameters. (Closed)

Created:
7 years, 6 months ago by asanka

Modified:
7 years, 6 months ago

Reviewers:
benjhayden, Jói

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, jam, joi+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Downloads] Remove RDH from DownloadUrlParameters. A ResourceDispatcherHost* doesn't need to be passed in DownloadUrlParameters since there's only one instance. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207710

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	content/browser/download/download_manager_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/download_url_parameters.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/public/browser/download_url_parameters.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 8 (0 generated)

asanka

PTAL. We don't gain anything from having the resource_dispatcher_host member in DownloadUrlParameters. But it complicates ...

7 years, 6 months ago (2013-06-19 18:46:19 UTC) #1

asanka

On 2013/06/20 19:35:23, benjhayden_chromium wrote: > lgtm Thanks!

7 years, 6 months ago (2013-06-20 20:25:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/16875007/1

7 years, 6 months ago (2013-06-20 21:37:18 UTC) #7

Message was sent while issue was closed.

Change committed as 207710