chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc - Issue 16871010: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Issue 16871010: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/notifications/balloon_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

index 3a2e57ef87505252cd51212708c8f13e1814f34b..8259ab748fd6b4f22de8321ba61ca1b1042d2ae2 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

@@ -451,7 +451,7 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest,

chrome::ToggleFullscreenMode(browser());

ASSERT_TRUE(controller()->IsEnabled());

- scoped_ptr<ImmersiveRevealedLock> lock(NULL);

+ scoped_ptr<ImmersiveRevealedLock> lock;

// 1) Test that if the mouse becomes hovered without the mouse moving due to a

// lock causing the top-of-window views to be revealed (and the mouse

@@ -496,8 +496,8 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest,

// GetRevealedLock() specific tests.

IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest, RevealedLock) {

- scoped_ptr<ImmersiveRevealedLock> lock1(NULL);

- scoped_ptr<ImmersiveRevealedLock> lock2(NULL);

+ scoped_ptr<ImmersiveRevealedLock> lock1;

+ scoped_ptr<ImmersiveRevealedLock> lock2;

// Immersive mode is not on by default.

EXPECT_FALSE(controller()->IsEnabled());