Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Issue 16871010: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, nona+watch_chromium.org, eroman, mmenke, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on CrOS in the chrome/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -50 lines) Patch
M chrome/browser/chromeos/cros/cros_library.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_stub.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_views.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
7 years, 6 months ago (2013-06-13 15:26:36 UTC) #1
Nico
lgtm Whoa, there's a lot of stuff remaining after doing this on linux. Now repeat ...
7 years, 6 months ago (2013-06-13 15:44:56 UTC) #2
dcheng
On 2013/06/13 15:44:56, Nico wrote: > lgtm > > Whoa, there's a lot of stuff ...
7 years, 6 months ago (2013-06-13 15:47:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16871010/1
7 years, 6 months ago (2013-06-13 15:48:31 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 00:03:41 UTC) #5
Message was sent while issue was closed.
Change committed as 206234

Powered by Google App Engine
This is Rietveld 408576698