Issue 16870008: Revert a workaround commit for a UAF crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16870008: Revert a workaround commit for a UAF crash. (Closed)

Created:
7 years, 6 months ago by yhirano

Modified:
7 years, 6 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert a workaround commit for a Use-After-Free crash. Revert a workaround commit r20158 for a Use-After-Free issue (http://crbug.com/244746) because a cleaner CL r207218 is landed. URLRequestContext does not inherit SupportsWeakPtr now. R=mmenke BUG=244746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207811

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -82 lines)			Patch
M	chrome/browser/net/chrome_url_request_context.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/socket_stream/socket_stream.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	net/socket_stream/socket_stream.cc	View	1	7 chunks	+8 lines, -13 lines	0 comments	Download
M	net/socket_stream/socket_stream_unittest.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download
M	net/url_request/url_request_context.h	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

yhirano

mmenke, can you review this CL? I reverted almost all, but some are not. - ...

7 years, 6 months ago (2013-06-20 05:56:18 UTC) #1

mmenke

On 2013/06/20 05:56:18, yhirano wrote: > mmenke, can you review this CL? > I reverted ...

7 years, 6 months ago (2013-06-20 14:10:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/16870008/2001

7 years, 6 months ago (2013-06-21 01:26:36 UTC) #3

Message was sent while issue was closed.

Change committed as 207811