Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: content/browser/indexed_db/indexed_db_leveldb_coding.cc

Issue 16870007: Switch database/file_identifier to std::string, remove createFromDatabaseIdentifier calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_leveldb_coding.cc
diff --git a/content/browser/indexed_db/indexed_db_leveldb_coding.cc b/content/browser/indexed_db/indexed_db_leveldb_coding.cc
index cedcb1bf84cf308fffe4ccd27fc6b2ec25cc7ca6..cbd3caf47e7db48007dc1b768ccd8dfb5b10c6c0 100644
--- a/content/browser/indexed_db/indexed_db_leveldb_coding.cc
+++ b/content/browser/indexed_db/indexed_db_leveldb_coding.cc
@@ -10,6 +10,8 @@
#include "base/logging.h"
#include "base/strings/string16.h"
+#include "base/strings/string_piece.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/sys_byteorder.h"
#include "content/browser/indexed_db/leveldb/leveldb_slice.h"
#include "content/common/indexed_db/indexed_db_key.h"
@@ -1277,24 +1279,24 @@ const char* DatabaseNameKey::Decode(const char* start,
return slice.begin();
}
-std::vector<char> DatabaseNameKey::Encode(const string16& origin,
+std::vector<char> DatabaseNameKey::Encode(const std::string& origin_identifier,
const string16& database_name) {
std::vector<char> ret = KeyPrefix::EncodeEmpty();
ret.push_back(kDatabaseNameTypeByte);
- EncodeStringWithLength(origin, &ret);
+ EncodeStringWithLength(base::ASCIIToUTF16(origin_identifier), &ret);
EncodeStringWithLength(database_name, &ret);
return ret;
}
std::vector<char> DatabaseNameKey::EncodeMinKeyForOrigin(
- const string16& origin) {
- return Encode(origin, string16());
+ const std::string& origin_identifier) {
+ return Encode(origin_identifier, string16());
}
std::vector<char> DatabaseNameKey::EncodeStopKeyForOrigin(
- const string16& origin) {
+ const std::string& origin_identifier) {
// just after origin in collation order
- return EncodeMinKeyForOrigin(origin + base::char16('\x01'));
+ return EncodeMinKeyForOrigin(origin_identifier + '\x01');
}
int DatabaseNameKey::Compare(const DatabaseNameKey& other) {

Powered by Google App Engine
This is Rietveld 408576698