Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: ui/views/examples/multiline_example.cc

Issue 16867016: Windows implementation of multiline RenderText (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: min height/baseline; update tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/examples/multiline_example.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/examples/multiline_example.cc
diff --git a/ui/views/examples/multiline_example.cc b/ui/views/examples/multiline_example.cc
index 8d13bf510c6231b715f5f302552e6a03f9504dcc..1df08aa1bdfb71368d254292eb9148f03696ba67 100644
--- a/ui/views/examples/multiline_example.cc
+++ b/ui/views/examples/multiline_example.cc
@@ -18,9 +18,10 @@ namespace examples {
// A simple View that hosts a RenderText object.
class MultilineExample::RenderTextView : public View {
public:
- explicit RenderTextView(gfx::RenderText* render_text)
- : render_text_(render_text) {
+ RenderTextView() : render_text_(gfx::RenderText::CreateInstance()) {
+ render_text_->SetHorizontalAlignment(gfx::ALIGN_CENTER);
render_text_->SetColor(SK_ColorBLACK);
+ render_text_->SetMultiline(true);
set_border(Border::CreateSolidBorder(2, SK_ColorGRAY));
}
@@ -30,13 +31,40 @@ class MultilineExample::RenderTextView : public View {
}
virtual gfx::Size GetPreferredSize() OVERRIDE {
- return gfx::Size(0,
- render_text_->font_list().GetHeight() + GetInsets().height());
+ // Turn off multiline mode to get the single-line text size, which is the
+ // preferred size for this view.
+ render_text_->SetMultiline(false);
+ gfx::Size size(render_text_->GetContentWidth(),
+ render_text_->GetStringSize().height());
+ size.Enlarge(GetInsets().width(), GetInsets().height());
+ render_text_->SetMultiline(true);
+ return size;
+ }
+
+ virtual int GetHeightForWidth(int w) OVERRIDE {
+ // TODO(ckocagil): Why does this happen?
+ if (w == 0)
+ return View::GetHeightForWidth(w);
+ gfx::Rect rect = render_text_->display_rect();
+ rect.set_width(w - GetInsets().width());
+ render_text_->SetDisplayRect(rect);
+ return render_text_->GetStringSize().height() + GetInsets().height();
}
void SetText(const string16& new_contents) {
+ // Color and style the text inside |test_range| to test colors and styles.
+ gfx::Range test_range(1, 21);
+ test_range.set_start(std::min(test_range.start(), new_contents.length()));
+ test_range.set_end(std::min(test_range.end(), new_contents.length()));
+
render_text_->SetText(new_contents);
- SchedulePaint();
+ render_text_->SetColor(SK_ColorBLACK);
+ render_text_->ApplyColor(0xFFFF0000, test_range);
+ render_text_->SetStyle(gfx::DIAGONAL_STRIKE, false);
+ render_text_->ApplyStyle(gfx::DIAGONAL_STRIKE, true, test_range);
+ render_text_->SetStyle(gfx::UNDERLINE, false);
+ render_text_->ApplyStyle(gfx::UNDERLINE, true, test_range);
+ InvalidateLayout();
}
private:
@@ -55,7 +83,8 @@ MultilineExample::MultilineExample()
: ExampleBase("Multiline RenderText"),
render_text_view_(NULL),
label_(NULL),
- textfield_(NULL) {
+ textfield_(NULL),
+ label_checkbox_(NULL) {
}
MultilineExample::~MultilineExample() {
@@ -65,17 +94,19 @@ void MultilineExample::CreateExampleView(View* container) {
const char kTestString[] = "test string asdf 1234 test string asdf 1234 "
"test string asdf 1234 test string asdf 1234";
- gfx::RenderText* render_text = gfx::RenderText::CreateInstance();
- render_text->SetText(ASCIIToUTF16(kTestString));
- render_text->SetHorizontalAlignment(gfx::ALIGN_CENTER);
-
- render_text_view_ = new RenderTextView(render_text);
+ render_text_view_ = new RenderTextView();
+ render_text_view_->SetText(ASCIIToUTF16(kTestString));
label_ = new Label();
label_->SetText(ASCIIToUTF16(kTestString));
label_->SetMultiLine(true);
label_->set_border(Border::CreateSolidBorder(2, SK_ColorCYAN));
+ label_checkbox_ = new Checkbox(ASCIIToUTF16("views::Label:"));
+ label_checkbox_->SetChecked(true);
+ label_checkbox_->set_listener(this);
+ label_checkbox_->set_request_focus_on_press(false);
+
textfield_ = new Textfield();
textfield_->SetController(this);
textfield_->SetText(ASCIIToUTF16(kTestString));
@@ -84,7 +115,7 @@ void MultilineExample::CreateExampleView(View* container) {
container->SetLayoutManager(layout);
ColumnSet* column_set = layout->AddColumnSet(0);
- column_set->AddColumn(GridLayout::LEADING, GridLayout::FILL,
+ column_set->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
0.0f, GridLayout::USE_PREF, 0, 0);
column_set->AddColumn(GridLayout::FILL, GridLayout::FILL,
1.0f, GridLayout::FIXED, 0, 0);
@@ -94,7 +125,7 @@ void MultilineExample::CreateExampleView(View* container) {
layout->AddView(render_text_view_);
layout->StartRow(0, 0);
- layout->AddView(new Label(ASCIIToUTF16("views::Label:")));
+ layout->AddView(label_checkbox_);
layout->AddView(label_);
layout->StartRow(0, 0);
@@ -105,7 +136,10 @@ void MultilineExample::CreateExampleView(View* container) {
void MultilineExample::ContentsChanged(Textfield* sender,
const string16& new_contents) {
render_text_view_->SetText(new_contents);
- label_->SetText(new_contents);
+ if (label_checkbox_->checked())
+ label_->SetText(new_contents);
+ container()->Layout();
+ container()->SchedulePaint();
}
bool MultilineExample::HandleKeyEvent(Textfield* sender,
@@ -113,5 +147,12 @@ bool MultilineExample::HandleKeyEvent(Textfield* sender,
return false;
}
+void MultilineExample::ButtonPressed(Button* sender, const ui::Event& event) {
+ DCHECK_EQ(sender, label_checkbox_);
+ label_->SetText(label_checkbox_->checked() ? textfield_->text() : string16());
+ container()->Layout();
+ container()->SchedulePaint();
+}
+
} // namespace examples
} // namespace views
« no previous file with comments | « ui/views/examples/multiline_example.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698