Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 16867002: [Android] Log the timeout used for each instrumentation test. (Closed)

Created:
7 years, 6 months ago by frankf
Modified:
7 years, 6 months ago
Reviewers:
craigdh, nilesh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Log the timeout used for each instrumentation test. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205980

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/android/pylib/instrumentation/test_runner.py View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
frankf
7 years, 6 months ago (2013-06-12 21:39:02 UTC) #1
nilesh
On 2013/06/12 21:39:02, frankf wrote: LGTM
7 years, 6 months ago (2013-06-12 21:53:43 UTC) #2
craigdh
lgtm with nit. https://codereview.chromium.org/16867002/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/16867002/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode309 build/android/pylib/instrumentation/test_runner.py:309: return self.adb.RunInstrumentationTest( Let's only print the ...
7 years, 6 months ago (2013-06-12 21:58:36 UTC) #3
frankf
https://codereview.chromium.org/16867002/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/16867002/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode309 build/android/pylib/instrumentation/test_runner.py:309: return self.adb.RunInstrumentationTest( Done. On 2013/06/12 21:58:37, craigdh wrote: > ...
7 years, 6 months ago (2013-06-12 22:08:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/16867002/5001
7 years, 6 months ago (2013-06-12 22:08:26 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 23:56:45 UTC) #6
Message was sent while issue was closed.
Change committed as 205980

Powered by Google App Engine
This is Rietveld 408576698