Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: content/renderer/media/media_stream_video_renderer_sink.cc

Issue 1686123004: Post GpuMemoryBufferVideoFramePool deletion on media thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Not using WeakPtr Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_stream_video_renderer_sink_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_video_renderer_sink.cc
diff --git a/content/renderer/media/media_stream_video_renderer_sink.cc b/content/renderer/media/media_stream_video_renderer_sink.cc
index 709f9d51d8f11139c35d11b2eb15235c36a52848..6fff1d9c81f58097bac9f37b1e307f3f24bb1c79 100644
--- a/content/renderer/media/media_stream_video_renderer_sink.cc
+++ b/content/renderer/media/media_stream_video_renderer_sink.cc
@@ -40,6 +40,10 @@ MediaStreamVideoRendererSink::MediaStreamVideoRendererSink(
}
MediaStreamVideoRendererSink::~MediaStreamVideoRendererSink() {
+ if (gpu_memory_buffer_pool_) {
+ media_task_runner_->DeleteSoon(FROM_HERE,
+ gpu_memory_buffer_pool_.release());
+ }
}
void MediaStreamVideoRendererSink::Start() {
@@ -109,6 +113,9 @@ void MediaStreamVideoRendererSink::OnVideoFrame(
return;
}
+ // |gpu_memory_buffer_pool_| deletion is going to be posted to
+ // |media_task_runner_|. base::Unretained() usage is fine since
+ // |gpu_memory_buffer_pool_| outlives the task.
media_task_runner_->PostTask(
FROM_HERE,
base::Bind(
« no previous file with comments | « no previous file | content/renderer/media/media_stream_video_renderer_sink_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698