chrome/common/extensions/docs/server2/persistent_object_store.py - Issue 16860003: Doc Server - Miscellaneous import, comment fixes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/persistent_object_store.py

Issue 16860003: Doc Server - Miscellaneous import, comment fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased with master Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/path_canonicalizer.py ('k') | chrome/common/extensions/docs/server2/sidenav_data_source.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from appengine_wrappers import db, IsDevServer	5 from appengine_wrappers import db, IsDevServer

6 from datastore_models import PersistentObjectStoreItem	6 from datastore_models import PersistentObjectStoreItem

7 from future import Future	7 from future import Future

8 import logging

9 from object_store import ObjectStore	8 from object_store import ObjectStore

10	9

11 class _AsyncGetFuture(object):	10 class _AsyncGetFuture(object):

12 def __init__(self, object_store, keys):	11 def __init__(self, object_store, keys):

13 self._futures = dict(	12 self._futures = dict(

14 (k, db.get_async(	13 (k, db.get_async(

15 PersistentObjectStoreItem.CreateKey(object_store._namespace, k)))	14 PersistentObjectStoreItem.CreateKey(object_store._namespace, k)))

16 for k in keys)	15 for k in keys)

17	16

18 def Get(self):	17 def Get(self):

(...skipping 22 matching lines...) Expand all Loading...
41	40

42 def DelMulti(self, keys):	41 def DelMulti(self, keys):

43 futures = []	42 futures = []

44 for key in keys:	43 for key in keys:

45 futures.append(db.delete_async(	44 futures.append(db.delete_async(

46 PersistentObjectStoreItem.CreateKey(self._namespace, key)))	45 PersistentObjectStoreItem.CreateKey(self._namespace, key)))

47 # If running the dev server, the futures don't complete until the server is	46 # If running the dev server, the futures don't complete until the server is

48 # quitting. This is annoying. Flush now.	47 # quitting. This is annoying. Flush now.

49 if IsDevServer():	48 if IsDevServer():

50 [future.wait() for future in futures]	49 [future.wait() for future in futures]

OLD	NEW