Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16845006: Fix LeakSanitizer annotations for NaCl. (Closed)

Created:
7 years, 6 months ago by earthdok
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix LeakSanitizer annotations for NaCl. NaCl code is not built with LSan runtime, so annotations should not be used. R=glider@chromium.org, jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/debug/leak_annotations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
7 years, 6 months ago (2013-06-17 13:23:20 UTC) #1
Alexander Potapenko
On 2013/06/17 13:23:20, earthdok wrote: LGTM
7 years, 6 months ago (2013-06-17 15:55:21 UTC) #2
jar (doing other things)
Rubber stamp LGTM
7 years, 6 months ago (2013-06-17 17:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/16845006/1
7 years, 6 months ago (2013-06-17 17:29:42 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 19:08:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 206766

Powered by Google App Engine
This is Rietveld 408576698