Issue 16836004: Route Android InputMsg operations through RenderWidgetHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16836004: Route Android InputMsg operations through RenderWidgetHost (Closed)

Created:
7 years, 6 months ago by jdduke (slow)

Modified:
7 years, 6 months ago

Reviewers:
aelias_OOO_until_Jul13, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Route Android InputMsg operations through RenderWidgetHost ImeAdapterAndroid and RenderWidgetHostViewAndroid perform several operations already found in RenderWidgetHostImpl. This patch delegates such operations to RWHI, consolidating exposure to InputMsg_*. BUG=245499 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206328

Patch Set 1 #

Patch Set 2 : Also fix RWHVA #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
M	content/browser/renderer_host/ime_adapter_android.cc	View		6 chunks	+5 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/public/browser/render_widget_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

PTAL. This is part of work to consolidate InputMsg* usage outside of RWHI. I'll add ...

7 years, 6 months ago (2013-06-12 20:46:31 UTC) #1

jdduke (slow)

jam: PTAL at content/public/browser/render_widget_host.h. Thanks!

7 years, 6 months ago (2013-06-13 13:28:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/16836004/2001

7 years, 6 months ago (2013-06-13 21:44:46 UTC) #5

Message was sent while issue was closed.

Change committed as 206328

Expand Messages | Collapse Messages