Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 16831022: Remove unnecessary Xcode setting for iOS builds. (Closed)

Created:
7 years, 6 months ago by lliabraa
Modified:
7 years, 6 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove unnecessary Xcode setting for iOS builds. The line being removed in this CL was originally added to prevent iOS builds from compiling for multiple archs. Since then, the VALID_ARCHS setting was added which accomplishes the same thing. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lliabraa
7 years, 6 months ago (2013-06-20 16:52:19 UTC) #1
stuartmorgan
LGTM
7 years, 6 months ago (2013-06-20 17:31:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/16831022/1
7 years, 6 months ago (2013-06-20 17:49:28 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 21:45:48 UTC) #4
Message was sent while issue was closed.
Change committed as 207588

Powered by Google App Engine
This is Rietveld 408576698