content/public/test/browser_test_utils.cc - Issue 16831021: Convert asynchronous closure test in cr.ui framework to a browser test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/browser_test_utils.cc

Issue 16831021: Convert asynchronous closure test in cr.ui framework to a browser test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/webui_resource_test.js ('K') | « chrome/test/data/webui/webui_resource_test.js ('k') | ui/webui/resources/js/cr/link_controller_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/browser_test_utils.cc

diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc

index b7db17d055591c3e5ba6607ecd490f34cdf4b86c..744579ba7760bd6ffbb50e7982e4950f5e77a991 100644

--- a/content/public/test/browser_test_utils.cc

+++ b/content/public/test/browser_test_utils.cc

@@ -504,8 +504,10 @@ bool DOMMessageQueue::WaitForMessage(std::string* message) {

// The queue should not be empty, unless we were quit because of a timeout.

if (message_queue_.empty())

return false;

- if (message)

+ if (message) {

*message = message_queue_.front();

+ message_queue_.pop();

sky 2013/06/20 23:26:26 Should the pop happen regardless of message being

kevers 2013/06/21 13:45:40 Good catch. Fixed.

+ }

return true;

}