fix mocking of various files in webkit_unit_tests

fix mocking of various files in webkit_unit_tests

so that https://codereview.chromium.org/17229012 doesn't dcheck.

R=jamesr@chromium.org
BUG=237267
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152760

[jamesr, 2013-06-19 23:40:35]

I'll mock your files!

lgtm, although I think you should avoid std::string since nearly all the APIs
you're calling need a WebString anyway

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
File Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp (right):

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:84: m_frameFilePath =
WebString::fromUTF8((m_baseFilePath + "iframes_test.html").c_str());
if m_baseFilePath was a WebString you wouldn't need this fromUTF8(), would you?

[scottmg, 2013-06-19 23:42:36]

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
File Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp (right):

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:84: m_frameFilePath =
WebString::fromUTF8((m_baseFilePath + "iframes_test.html").c_str());
On 2013/06/19 23:40:35, jamesr wrote:
> if m_baseFilePath was a WebString you wouldn't need this fromUTF8(), would
you?

WebString doesn't have an operator+? but yeah.

[jamesr, 2013-06-19 23:43:06]

It does have a lot of append()s

[scottmg, 2013-06-19 23:59:42]

On 2013/06/19 23:43:06, jamesr wrote:
> It does have a lot of append()s

sorry, i'm an idiot. do you mean i should use WTF::String locally? i can't find
WebString::append or any append that looks like it'd get found by ADL for
WebString.

[jamesr, 2013-06-20 00:00:26]

On 2013/06/19 23:59:42, scottmg wrote:
> On 2013/06/19 23:43:06, jamesr wrote:
> > It does have a lot of append()s
> 
> sorry, i'm an idiot. do you mean i should use WTF::String locally? i can't
find
> WebString::append or any append that looks like it'd get found by ADL for
> WebString.

Ah sorry, my bad.  These tests are inside the DLL so you can use WTF::String
directly.

[scottmg, 2013-06-20 00:31:53]

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
File Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp (right):

https://codereview.chromium.org/16831015/diff/1/Source/WebKit/chromium/tests/...
Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:84: m_frameFilePath =
WebString::fromUTF8((m_baseFilePath + "iframes_test.html").c_str());
On 2013/06/19 23:40:35, jamesr wrote:
> if m_baseFilePath was a WebString you wouldn't need this fromUTF8(), would
you?

Done.

[commit-bot: I haz the power, 2013-06-20 01:54:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/16831015/9001

[commit-bot: I haz the power, 2013-06-20 07:07:55]

Change committed as 152760