Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16831010: Move some classes out of webkit/glue/. (Closed)

Created:
7 years, 6 months ago by darin (slow to review)
Modified:
7 years, 6 months ago
Reviewers:
michaeln, palmer, jamesr
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, pfeldman
Visibility:
Public.

Description

Move some classes out of webkit/glue/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208865

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Make webkit_common depend on webkit_base #

Patch Set 4 : storage_browser should link against webkit_common #

Patch Set 5 : Move UploadDataStreamBuilder to content/browser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -790 lines) Patch
M content/browser/devtools/devtools_netlog_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_netlog_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
A content/browser/loader/upload_data_stream_builder.h View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A + content/browser/loader/upload_data_stream_builder.cc View 1 2 3 4 5 chunks +47 lines, -75 lines 0 comments Download
A + content/browser/loader/upload_data_stream_builder_unittest.cc View 1 2 3 4 12 chunks +42 lines, -22 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M webkit/base/webkit_base.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A webkit/common/resource_devtools_info.h View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/common/resource_devtools_info.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A + webkit/common/resource_request_body.h View 3 chunks +6 lines, -34 lines 0 comments Download
A webkit/common/resource_request_body.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A webkit/common/resource_response_info.h View 1 chunk +103 lines, -0 lines 0 comments Download
A webkit/common/resource_response_info.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M webkit/common/webkit_common.gypi View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 chunk +1 line, -108 lines 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/glue/resource_request_body.h View 1 chunk +0 lines, -93 lines 0 comments Download
D webkit/glue/resource_request_body.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D webkit/glue/resource_request_body_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
darin (slow to review)
7 years, 6 months ago (2013-06-19 15:10:42 UTC) #1
michaeln
lgtm
7 years, 6 months ago (2013-06-19 21:29:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/16831010/1
7 years, 6 months ago (2013-06-20 05:07:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10575
7 years, 6 months ago (2013-06-20 05:24:35 UTC) #4
darin (slow to review)
+palmer for IPC review
7 years, 6 months ago (2013-06-20 05:39:31 UTC) #5
palmer
Rubberstamp LGTM
7 years, 6 months ago (2013-06-20 17:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/16831010/16001
7 years, 6 months ago (2013-06-20 18:08:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=85707
7 years, 6 months ago (2013-06-20 20:04:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/16831010/31001
7 years, 6 months ago (2013-06-20 20:55:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=63430
7 years, 6 months ago (2013-06-20 21:28:06 UTC) #10
darin (slow to review)
+jamesr: PTAL at the content/ changes. This is just incrementally different than what michaeln@ already ...
7 years, 6 months ago (2013-06-26 21:32:39 UTC) #11
jamesr
lgtm!
7 years, 6 months ago (2013-06-26 23:05:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/16831010/47001
7 years, 6 months ago (2013-06-26 23:48:02 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-27 08:00:50 UTC) #14
Message was sent while issue was closed. 
Change committed as 208865

Powered by Google App Engine
This is Rietveld 408576698