Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/ic.cc

Issue 16826016: Implement IC support for Constant Function transitions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1715 matching lines...) Expand 10 before | Expand all | Expand 10 after
1726 case TRANSITION: { 1726 case TRANSITION: {
1727 // Explicitly pass in the receiver map since LookupForWrite may have 1727 // Explicitly pass in the receiver map since LookupForWrite may have
1728 // stored something else than the receiver in the holder. 1728 // stored something else than the receiver in the holder.
1729 Handle<Map> transition( 1729 Handle<Map> transition(
1730 lookup->GetTransitionTarget(receiver->map()), isolate()); 1730 lookup->GetTransitionTarget(receiver->map()), isolate());
1731 int descriptor = transition->LastAdded(); 1731 int descriptor = transition->LastAdded();
1732 1732
1733 DescriptorArray* target_descriptors = transition->instance_descriptors(); 1733 DescriptorArray* target_descriptors = transition->instance_descriptors();
1734 PropertyDetails details = target_descriptors->GetDetails(descriptor); 1734 PropertyDetails details = target_descriptors->GetDetails(descriptor);
1735 1735
1736 if (details.type() != FIELD || details.attributes() != NONE) break; 1736 if (details.type() == CALLBACKS || details.attributes() != NONE) break;
1737 1737
1738 return isolate()->stub_cache()->ComputeStoreTransition( 1738 return isolate()->stub_cache()->ComputeStoreTransition(
1739 name, receiver, lookup, transition, strict_mode); 1739 name, receiver, lookup, transition, strict_mode);
1740 } 1740 }
1741 case NONEXISTENT: 1741 case NONEXISTENT:
1742 case HANDLER: 1742 case HANDLER:
1743 UNREACHABLE(); 1743 UNREACHABLE();
1744 break; 1744 break;
1745 } 1745 }
1746 return Handle<Code>::null(); 1746 return Handle<Code>::null();
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
2092 case TRANSITION: { 2092 case TRANSITION: {
2093 // Explicitly pass in the receiver map since LookupForWrite may have 2093 // Explicitly pass in the receiver map since LookupForWrite may have
2094 // stored something else than the receiver in the holder. 2094 // stored something else than the receiver in the holder.
2095 Handle<Map> transition( 2095 Handle<Map> transition(
2096 lookup->GetTransitionTarget(receiver->map()), isolate()); 2096 lookup->GetTransitionTarget(receiver->map()), isolate());
2097 int descriptor = transition->LastAdded(); 2097 int descriptor = transition->LastAdded();
2098 2098
2099 DescriptorArray* target_descriptors = transition->instance_descriptors(); 2099 DescriptorArray* target_descriptors = transition->instance_descriptors();
2100 PropertyDetails details = target_descriptors->GetDetails(descriptor); 2100 PropertyDetails details = target_descriptors->GetDetails(descriptor);
2101 2101
2102 if (details.type() == FIELD && details.attributes() == NONE) { 2102 if (details.type() != CALLBACKS && details.attributes() == NONE) {
2103 return isolate()->stub_cache()->ComputeKeyedStoreTransition( 2103 return isolate()->stub_cache()->ComputeKeyedStoreTransition(
2104 name, receiver, lookup, transition, strict_mode); 2104 name, receiver, lookup, transition, strict_mode);
2105 } 2105 }
2106 // fall through. 2106 // fall through.
2107 } 2107 }
2108 case NORMAL: 2108 case NORMAL:
2109 case CONSTANT_FUNCTION: 2109 case CONSTANT_FUNCTION:
2110 case CALLBACKS: 2110 case CALLBACKS:
2111 case INTERCEPTOR: 2111 case INTERCEPTOR:
2112 // Always rewrite to the generic case so that we do not 2112 // Always rewrite to the generic case so that we do not
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
3052 #undef ADDR 3052 #undef ADDR
3053 }; 3053 };
3054 3054
3055 3055
3056 Address IC::AddressFromUtilityId(IC::UtilityId id) { 3056 Address IC::AddressFromUtilityId(IC::UtilityId id) {
3057 return IC_utilities[id]; 3057 return IC_utilities[id];
3058 } 3058 }
3059 3059
3060 3060
3061 } } // namespace v8::internal 3061 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698