Source/core/css/resolver/ViewportStyleResolver.cpp - Issue 16826008: [css-device-adapt] Implemented spec changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/ViewportStyleResolver.cpp

Issue 16826008: [css-device-adapt] Implemented spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Corrected expectations for tests added after original upload. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/ViewportStyleResolver.cpp

diff --git a/Source/core/css/resolver/ViewportStyleResolver.cpp b/Source/core/css/resolver/ViewportStyleResolver.cpp

index b3d86daeaaed6cd68af5f5e08edbc42805891fa4..539cb0e4ab7199d2cbd6381f475980c8cf988c9e 100644

--- a/Source/core/css/resolver/ViewportStyleResolver.cpp

+++ b/Source/core/css/resolver/ViewportStyleResolver.cpp

@@ -123,11 +123,9 @@ float ViewportStyleResolver::getViewportArgumentValue(CSSPropertyID id) const

switch (id) {

case CSSPropertyMaxHeight:

case CSSPropertyMinHeight:

- ASSERT(m_document->initialViewportSize().height() > 0);

return percentValue * m_document->initialViewportSize().height();

case CSSPropertyMaxWidth:

case CSSPropertyMinWidth:

- ASSERT(m_document->initialViewportSize().width() > 0);

return percentValue * m_document->initialViewportSize().width();

case CSSPropertyMaxZoom:

case CSSPropertyMinZoom: