Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: media/filters/audio_renderer_impl.h

Issue 16823003: Replace erroneous use of base::Time with base::TimeTicks throughout media code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/PresubmitPromptWarning/PresubmitPromptOrNotify/ Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/audio_renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_impl.h
diff --git a/media/filters/audio_renderer_impl.h b/media/filters/audio_renderer_impl.h
index d96bfdd152eaa9e15776bb9615e03edb974c1f08..43c106d0b9c88dca69ce8073f998e81acb90d706 100644
--- a/media/filters/audio_renderer_impl.h
+++ b/media/filters/audio_renderer_impl.h
@@ -88,7 +88,7 @@ class MEDIA_EXPORT AudioRendererImpl
void DisableUnderflowForTesting();
// Allows injection of a custom time callback for non-realtime testing.
- typedef base::Callback<base::Time()> NowCB;
+ typedef base::Callback<base::TimeTicks()> NowCB;
void set_now_cb_for_testing(const NowCB& now_cb) {
now_cb_ = now_cb;
}
@@ -131,8 +131,8 @@ class MEDIA_EXPORT AudioRendererImpl
// Estimate earliest time when current buffer can stop playing.
void UpdateEarliestEndTime_Locked(int frames_filled,
- base::TimeDelta playback_delay,
- base::Time time_now);
+ const base::TimeDelta& playback_delay,
+ const base::TimeTicks& time_now);
void DoPlay();
void DoPause();
@@ -203,7 +203,7 @@ class MEDIA_EXPORT AudioRendererImpl
// Callback provided to Preroll().
PipelineStatusCB preroll_cb_;
- // Typically calls base::Time::Now() but can be overridden by a test.
+ // Typically calls base::TimeTicks::Now() but can be overridden by a test.
NowCB now_cb_;
// After Initialize() has completed, all variables below must be accessed
@@ -256,7 +256,7 @@ class MEDIA_EXPORT AudioRendererImpl
// empty till that time. Workaround is not bulletproof, as we don't exactly
// know when that particular data would start playing, but it is much better
// than nothing.
- base::Time earliest_end_time_;
+ base::TimeTicks earliest_end_time_;
size_t total_frames_filled_;
bool underflow_disabled_;
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/audio_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698