Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: src/hydrogen-instructions.h

Issue 16818016: Remove manual representation annotations for constants. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3223 matching lines...) Expand 10 before | Expand all | Expand 10 after
3234 3234
3235 private: 3235 private:
3236 virtual bool IsDeletable() const { return true; } 3236 virtual bool IsDeletable() const { return true; }
3237 3237
3238 ZoneList<HValue*> values_; 3238 ZoneList<HValue*> values_;
3239 }; 3239 };
3240 3240
3241 3241
3242 class HConstant: public HTemplateInstruction<0> { 3242 class HConstant: public HTemplateInstruction<0> {
3243 public: 3243 public:
3244 HConstant(Handle<Object> handle, Representation r); 3244 HConstant(Handle<Object> handle, Representation r = Representation::None());
3245 HConstant(int32_t value, 3245 HConstant(int32_t value,
3246 Representation r = Representation::None(), 3246 Representation r = Representation::None(),
3247 bool is_not_in_new_space = true, 3247 bool is_not_in_new_space = true,
3248 Handle<Object> optional_handle = Handle<Object>::null()); 3248 Handle<Object> optional_handle = Handle<Object>::null());
3249 HConstant(double value, 3249 HConstant(double value,
3250 Representation r = Representation::None(), 3250 Representation r = Representation::None(),
3251 bool is_not_in_new_space = true, 3251 bool is_not_in_new_space = true,
3252 Handle<Object> optional_handle = Handle<Object>::null()); 3252 Handle<Object> optional_handle = Handle<Object>::null());
3253 HConstant(Handle<Object> handle, 3253 HConstant(Handle<Object> handle,
3254 UniqueValueId unique_id, 3254 UniqueValueId unique_id,
(...skipping 3353 matching lines...) Expand 10 before | Expand all | Expand 10 after
6608 virtual bool IsDeletable() const { return true; } 6608 virtual bool IsDeletable() const { return true; }
6609 }; 6609 };
6610 6610
6611 6611
6612 #undef DECLARE_INSTRUCTION 6612 #undef DECLARE_INSTRUCTION
6613 #undef DECLARE_CONCRETE_INSTRUCTION 6613 #undef DECLARE_CONCRETE_INSTRUCTION
6614 6614
6615 } } // namespace v8::internal 6615 } } // namespace v8::internal
6616 6616
6617 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6617 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698