Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 16818016: Remove manual representation annotations for constants. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove manual representation annotations for constants. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15130

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -88 lines) Patch
M src/code-stubs-hydrogen.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 38 chunks +52 lines, -80 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-13 17:02:27 UTC) #1
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc#newcode1415 src/hydrogen.cc:1415: Handle<FixedArray>(isolate()->heap()->empty_fixed_array())); I know this is not ...
7 years, 6 months ago (2013-06-13 17:33:56 UTC) #2
Toon Verwaest
Addressed comments. https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc#newcode1415 src/hydrogen.cc:1415: Handle<FixedArray>(isolate()->heap()->empty_fixed_array())); On 2013/06/13 17:33:56, Michael Starzinger wrote: ...
7 years, 6 months ago (2013-06-13 17:37:56 UTC) #3
Toon Verwaest
7 years, 6 months ago (2013-06-13 17:38:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698