Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 16818014: Only extend storage if FIELD (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 843
844 __ bind(&do_store); 844 __ bind(&do_store);
845 __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0); 845 __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0);
846 } 846 }
847 847
848 // Stub never generated for non-global objects that require access 848 // Stub never generated for non-global objects that require access
849 // checks. 849 // checks.
850 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded()); 850 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
851 851
852 // Perform map transition for the receiver if necessary. 852 // Perform map transition for the receiver if necessary.
853 if (object->map()->unused_property_fields() == 0) { 853 if (details.type() == FIELD &&
854 object->map()->unused_property_fields() == 0) {
854 // The properties must be extended before we can store the value. 855 // The properties must be extended before we can store the value.
855 // We jump to a runtime call that extends the properties array. 856 // We jump to a runtime call that extends the properties array.
856 __ pop(scratch1); // Return address. 857 __ pop(scratch1); // Return address.
857 __ push(receiver_reg); 858 __ push(receiver_reg);
858 __ Push(transition); 859 __ Push(transition);
859 __ push(value_reg); 860 __ push(value_reg);
860 __ push(scratch1); 861 __ push(scratch1);
861 __ TailCallExternalReference( 862 __ TailCallExternalReference(
862 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage), 863 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
863 masm->isolate()), 864 masm->isolate()),
(...skipping 2630 matching lines...) Expand 10 before | Expand all | Expand 10 after
3494 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3495 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3495 } 3496 }
3496 } 3497 }
3497 3498
3498 3499
3499 #undef __ 3500 #undef __
3500 3501
3501 } } // namespace v8::internal 3502 } } // namespace v8::internal
3502 3503
3503 #endif // V8_TARGET_ARCH_X64 3504 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698