Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 16818014: Only extend storage if FIELD (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 540
541 __ bind(&do_store); 541 __ bind(&do_store);
542 __ vstr(d0, FieldMemOperand(storage_reg, HeapNumber::kValueOffset)); 542 __ vstr(d0, FieldMemOperand(storage_reg, HeapNumber::kValueOffset));
543 } 543 }
544 544
545 // Stub never generated for non-global objects that require access 545 // Stub never generated for non-global objects that require access
546 // checks. 546 // checks.
547 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded()); 547 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
548 548
549 // Perform map transition for the receiver if necessary. 549 // Perform map transition for the receiver if necessary.
550 if (object->map()->unused_property_fields() == 0) { 550 if (details.type() == FIELD &&
551 object->map()->unused_property_fields() == 0) {
551 // The properties must be extended before we can store the value. 552 // The properties must be extended before we can store the value.
552 // We jump to a runtime call that extends the properties array. 553 // We jump to a runtime call that extends the properties array.
553 __ push(receiver_reg); 554 __ push(receiver_reg);
554 __ mov(r2, Operand(transition)); 555 __ mov(r2, Operand(transition));
555 __ Push(r2, r0); 556 __ Push(r2, r0);
556 __ TailCallExternalReference( 557 __ TailCallExternalReference(
557 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage), 558 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
558 masm->isolate()), 559 masm->isolate()),
559 3, 560 3,
560 1); 561 1);
(...skipping 3084 matching lines...) Expand 10 before | Expand all | Expand 10 after
3645 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3646 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3646 } 3647 }
3647 } 3648 }
3648 3649
3649 3650
3650 #undef __ 3651 #undef __
3651 3652
3652 } } // namespace v8::internal 3653 } } // namespace v8::internal
3653 3654
3654 #endif // V8_TARGET_ARCH_ARM 3655 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698