Issue 16812003: Adding useful scripts to parse revision info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16812003: Adding useful scripts to parse revision info. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Adding useful scripts to parse revision info. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15078

Patch Set 2 : Always execute v8-info in the right dir #

Patch Set 7 : Add -h and options to v8-rolls.sh #

Total comments: 2

Patch Set 8 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+255 lines, -0 lines)			Patch
	A	tools/v8-info.sh	View	1 2 3 4	1 chunk	+135 lines, -0 lines	0 comments	Download
	A	tools/v8-rolls.sh	View	1 2 3 4 5 6 7	1 chunk	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a comment. https://chromiumcodereview.appspot.com/16812003/diff/17001/tools/v8-rolls.sh File tools/v8-rolls.sh (right): https://chromiumcodereview.appspot.com/16812003/diff/17001/tools/v8-rolls.sh#newcode44 tools/v8-rolls.sh:44: h) usage This isn't JavaScript. ...

7 years, 6 months ago (2013-06-12 10:31:07 UTC) #2

Toon Verwaest

Committed patchset #8 manually as r15078 (presubmit successful).

7 years, 6 months ago (2013-06-12 10:39:58 UTC) #3

Toon Verwaest

7 years, 6 months ago (2013-06-12 10:43:16 UTC) #4

Message was sent while issue was closed.

Addressed comments. Landed.

https://chromiumcodereview.appspot.com/16812003/diff/17001/tools/v8-rolls.sh
File tools/v8-rolls.sh (right):

https://chromiumcodereview.appspot.com/16812003/diff/17001/tools/v8-rolls.sh#...
tools/v8-rolls.sh:44: h)  usage
On 2013/06/12 10:31:07, Jakob wrote:
> This isn't JavaScript. There are rules. You can't call a function before
> defining it.

Done.

Expand Messages | Collapse Messages

Issue 16812003: Adding useful scripts to parse revision info. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Always execute v8-info in the right dir #

Patch Set 3 : Fix up -h #

Patch Set 4 : Cleanup -h #

Patch Set 5 : Spaces #

Patch Set 6 : #

Patch Set 7 : Add -h and options to v8-rolls.sh #

Patch Set 8 : #

Messages