Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6525)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 1680743006: [Media Router] Show user email in header if cloud sink is present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address final comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
index 4a2bd33a44766bb793c8cd635ef61e7483b212e5..9b7abad9c1280349ed9d472cf5ee778282594c49 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
@@ -298,6 +298,15 @@ Polymer({
},
/**
+ * Whether to show the user domain of sinks associated with identity.
+ * @type {boolean}
+ */
+ showDomain: {
+ type: Boolean,
+ value: false,
+ },
+
+ /**
* Whether to show the first run flow.
* @type {boolean}
*/
@@ -382,6 +391,7 @@ Polymer({
},
listeners: {
+ 'header-height-changed': 'updateElementPositioning_',
'header-or-arrow-click': 'toggleCastModeHidden_',
'mouseleave': 'onMouseLeave_',
'mouseenter': 'onMouseEnter_',
@@ -731,9 +741,7 @@ Polymer({
* @private
*/
computeSinkDomainHidden_: function(sink) {
- // TODO(amp): Check the domain of Chrome profile identity and only show the
- // sink domain if it doesn't match the profile domain. crbug.com/570797
- return this.isEmptyOrWhitespace_(sink.domain);
+ return !this.showDomain || this.isEmptyOrWhitespace_(sink.domain);
},
/**

Powered by Google App Engine
This is Rietveld 408576698