Issue 16802003: Add sample usage / output and -u option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16802003: Add sample usage / output and -u option (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add sample usage / output and -u option R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15091

Patch Set 2 : Addressed comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	tools/v8-info.sh	View	1	4 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://chromiumcodereview.appspot.com/16802003/diff/1/tools/v8-info.sh File tools/v8-info.sh (right): https://chromiumcodereview.appspot.com/16802003/diff/1/tools/v8-info.sh#newcode55 tools/v8-info.sh:55: Example usage: <v8-info> -i 3.19.10$ You can s/<v8-info>/$0/, ...

7 years, 6 months ago (2013-06-12 12:02:23 UTC) #2

Toon Verwaest

Addressed comment https://chromiumcodereview.appspot.com/16802003/diff/1/tools/v8-info.sh File tools/v8-info.sh (right): https://chromiumcodereview.appspot.com/16802003/diff/1/tools/v8-info.sh#newcode55 tools/v8-info.sh:55: Example usage: <v8-info> -i 3.19.10$ On 2013/06/12 ...

7 years, 6 months ago (2013-06-12 15:35:48 UTC) #3

Toon Verwaest

7 years, 6 months ago (2013-06-12 15:36:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15091 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16802003: Add sample usage / output and -u option (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages