[Contextual Search] Update GetUrlForContextualSearchQuery.

[Contextual Search] Update GetUrlForContextualSearchQuery.

Add a protocol parameter to GetUrlForContextualSearchQuery so Contextual Search can specify which protocol to use when building a Search query.

BUG=526291
Committed: https://crrev.com/3485f21ab9029c9c0e67602a128d5169315b8967
Cr-Commit-Position: refs/heads/master@{#374537}

[Donn Denman, 2016-02-09 00:14:24]

donnd@chromium.org changed reviewers:
+ pkasting@chromium.org

[Donn Denman, 2016-02-09 00:14:25]

Peter, PTAL.  Thanks!

[Peter Kasting, 2016-02-09 00:38:41]

LGTM

[Donn Denman, 2016-02-09 18:44:54]

donnd@chromium.org changed reviewers:
+ newt@chromium.org, pedrosimonetti@chromium.org
- pkasting@chromium.org

[Donn Denman, 2016-02-09 18:44:55]

Newton, PTAL for OWNERS approval on chrome/android/...TemplateUrlService* files.

Pedro, PTAL at least for OWNERs on  */contextualsearch/*.

Thanks!

[newt (away), 2016-02-09 21:17:01]

See question inline.

If the protocol version *does* need to be configurable, after all, then lgtm.
Otherwise, it'd be simpler to simply change the hardcoded "2" value in
template_url_service_android.cc.

https://chromiumcodereview.appspot.com/1679893002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://chromiumcodereview.appspot.com/1679893002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:285:
* @param protocolVersion The version of the Contextual Search API protocol to
use.
Except for tests, we only pass in a single value for protocolVersion: "2". Does
this need to be configurable via a parameter?

[Donn Denman, 2016-02-09 21:41:51]

https://chromiumcodereview.appspot.com/1679893002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://chromiumcodereview.appspot.com/1679893002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:285:
* @param protocolVersion The version of the Contextual Search API protocol to
use.
On 2016/02/09 21:17:01, newt (slow) wrote:
> Except for tests, we only pass in a single value for protocolVersion: "2".
Does
> this need to be configurable via a parameter?

Yes, we're in transition to a "Single-Request" model, so we'll be sending both
"2" and "3" until we're fully transitioned.  It's a big change so I'm trying to
land these prerequisites separately.

[newt (away), 2016-02-09 22:06:11]

Sounds good. lgtm.

[Donn Denman, 2016-02-09 22:07:32]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2016-02-09 22:07:32]

Theresa, PTAL at least for OWNERs on  */contextualsearch/*.

[pedro (no code reviews), 2016-02-09 22:47:29]

lgtm

[Donn Denman, 2016-02-09 22:59:14]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:04:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679893002/1

[commit-bot: I haz the power, 2016-02-09 23:52:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-09 23:53:30]

Description was changed from

==========
[Contextual Search] Update GetUrlForContextualSearchQuery.

Add a protocol parameter to GetUrlForContextualSearchQuery so Contextual Search
can specify which protocol to use when building a Search query.

BUG=526291
==========

to

==========
[Contextual Search] Update GetUrlForContextualSearchQuery.

Add a protocol parameter to GetUrlForContextualSearchQuery so Contextual Search
can specify which protocol to use when building a Search query.

BUG=526291

Committed: https://crrev.com/3485f21ab9029c9c0e67602a128d5169315b8967
Cr-Commit-Position: refs/heads/master@{#374537}
==========

[commit-bot: I haz the power, 2016-02-09 23:53:31]

Patchset 1 (id:??) landed as
https://crrev.com/3485f21ab9029c9c0e67602a128d5169315b8967
Cr-Commit-Position: refs/heads/master@{#374537}