Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 167963003: Support for distilling prior pages in an article. (Closed)

Created:
6 years, 10 months ago by shashi
Modified:
6 years, 10 months ago
Reviewers:
cjhopman, Yaron, nyquist
CC:
chromium-reviews
Visibility:
Public.

Description

Support for distilling prior pages in an article. If distillation is triggered on a page other than the first page, the distiller only distills the subsequent pages in the article. Add support for distilling prior pages. This only adds support to the C++ side, the javascript is still missing the heuristic to figure out previous pages. BUG=288015 TEST=Included. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251654

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -11 lines) Patch
M components/dom_distiller/core/distiller.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 1 2 7 chunks +78 lines, -8 lines 0 comments Download
M components/dom_distiller/core/page_distiller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/page_distiller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/readability/js/readability.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
shashi
Depends on https://codereview.chromium.org/130543003/ to land.
6 years, 10 months ago (2014-02-15 00:21:10 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/167963003/diff/50001/components/dom_distiller/core/distiller.cc File components/dom_distiller/core/distiller.cc (right): https://codereview.chromium.org/167963003/diff/50001/components/dom_distiller/core/distiller.cc#newcode164 components/dom_distiller/core/distiller.cc:164: AddToDistillationQueue(page_num - 1, prev_page_url); nit: this could be ...
6 years, 10 months ago (2014-02-15 02:45:53 UTC) #2
shashi
https://chromiumcodereview.appspot.com/167963003/diff/50001/components/dom_distiller/core/distiller.cc File components/dom_distiller/core/distiller.cc (right): https://chromiumcodereview.appspot.com/167963003/diff/50001/components/dom_distiller/core/distiller.cc#newcode164 components/dom_distiller/core/distiller.cc:164: AddToDistillationQueue(page_num - 1, prev_page_url); On 2014/02/15 02:45:53, cjhopman wrote: ...
6 years, 10 months ago (2014-02-17 03:43:20 UTC) #3
shashi
The CQ bit was checked by shashishekhar@chromium.org
6 years, 10 months ago (2014-02-17 03:43:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/167963003/210001
6 years, 10 months ago (2014-02-17 03:43:35 UTC) #5
shashi
The CQ bit was unchecked by shashishekhar@chromium.org
6 years, 10 months ago (2014-02-17 03:47:13 UTC) #6
shashi
The CQ bit was checked by shashishekhar@chromium.org
6 years, 10 months ago (2014-02-17 03:47:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/167963003/330001
6 years, 10 months ago (2014-02-17 03:47:46 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 11:02:55 UTC) #9
Message was sent while issue was closed.
Change committed as 251654

Powered by Google App Engine
This is Rietveld 408576698