Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 16794003: Include MSE duration testSetZero, nix early ending (Closed)

Created:
7 years, 6 months ago by wolenetz
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Include MSE duration testSetZero, nix early ending Add testSetZero case to MSE duration boundarycondition layout test. Remove explicit endTest() from testSetPositiveDouble and testSetZero for full logging. Update test expectation accordingly. R=acolwell@chromium.org TEST=MSE layout tests pass on linux chromium Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M LayoutTests/http/tests/media/media-source/webkitmediasource-duration-boundaryconditions.html View 2 chunks +4 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/webkitmediasource-duration-boundaryconditions-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wolenetz
PTAL. Do I need to add any other reviewers?
7 years, 6 months ago (2013-06-11 22:12:06 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 6 months ago (2013-06-11 22:19:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/16794003/1
7 years, 6 months ago (2013-06-11 22:20:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1489
7 years, 6 months ago (2013-06-11 23:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/16794003/1
7 years, 6 months ago (2013-06-11 23:49:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9615
7 years, 6 months ago (2013-06-12 02:40:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/16794003/1
7 years, 6 months ago (2013-06-12 05:53:05 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 06:48:17 UTC) #8
Message was sent while issue was closed.
Change committed as 152269

Powered by Google App Engine
This is Rietveld 408576698