Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 16776005: net: use IsSecureScheme rather than matching "https". (Closed)

Created:
7 years, 6 months ago by agl
Modified:
7 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi
Visibility:
Public.

Description

net: use IsSecureScheme rather than matching "https". My r202927 matched against a scheme of "https" in order to be consistent with the other users in the same file. But it appears that IsSecureScheme is the better answer throughout the file. BUG=244260 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205898

Patch Set 1 #

Total comments: 2

Patch Set 2 : ERR_HEADERS_TRUNCATED => ERR_RESPONSE_HEADERS_TRUNCATED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M net/base/net_error_list.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy2_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy3_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_parser.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
agl
7 years, 6 months ago (2013-06-11 16:54:47 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/16776005/diff/1/net/http/http_stream_parser.cc File net/http/http_stream_parser.cc (right): https://codereview.chromium.org/16776005/diff/1/net/http/http_stream_parser.cc#newcode552 net/http/http_stream_parser.cc:552: return ERR_HEADERS_TRUNCATED; Nit: Can you ...
7 years, 6 months ago (2013-06-11 17:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/16776005/5001
7 years, 6 months ago (2013-06-11 20:58:05 UTC) #3
agl
https://codereview.chromium.org/16776005/diff/1/net/http/http_stream_parser.cc File net/http/http_stream_parser.cc (right): https://codereview.chromium.org/16776005/diff/1/net/http/http_stream_parser.cc#newcode552 net/http/http_stream_parser.cc:552: return ERR_HEADERS_TRUNCATED; On 2013/06/11 17:49:33, wtc wrote: > > ...
7 years, 6 months ago (2013-06-11 20:58:39 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 23:20:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/16776005/5001
7 years, 6 months ago (2013-06-12 19:01:00 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 19:43:04 UTC) #7
Message was sent while issue was closed.
Change committed as 205898

Powered by Google App Engine
This is Rietveld 408576698